Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cfml support #376

Merged
merged 34 commits into from Apr 10, 2022
Merged

Cfml support #376

merged 34 commits into from Apr 10, 2022

Conversation

scottsteinbeck
Copy link
Contributor

Added support for CFML - ColdFusion/Lucee support for the curl converter site.

@scottsteinbeck
Copy link
Contributor Author

@verhovsky, if you had a chance, could you take a look at the updated PR, Thanks!

src/generators/cfml.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
scottsteinbeck and others added 5 commits April 7, 2022 08:23
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
…Updated tests to allot for generator changes
package-lock.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
src/generators/cfml.ts Outdated Show resolved Hide resolved
scottsteinbeck and others added 3 commits April 8, 2022 15:14
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
@scottsteinbeck
Copy link
Contributor Author

@verhovsky I updated the code to use your suggestion, just modified it slightly to default the proxy port to 1080. It is stored as a string let proxyPort = '1080' due to the TS validation getting mad at the variable TYPE change from string to number. This should not affect anything since it is still being added to the final output as a string.

@verhovsky
Copy link
Member

We can't add it to the VS Code extension because it has to ship an old version, see curlconverter/curlconverter-vscode#1. I'll add it to the site myself, but it'll be hard because we've run out of room.

Screen Shot 2022-04-08 at 17 09 14

src/generators/cfml.ts Outdated Show resolved Hide resolved
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
src/generators/cfml.ts Outdated Show resolved Hide resolved
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
src/generators/cfml.ts Outdated Show resolved Hide resolved
@scottsteinbeck
Copy link
Contributor Author

would you mind checking through the rest of cfml.ts to give me all the remaining code feedback in one review that way i can address it without having to ping you so often

@scottsteinbeck
Copy link
Contributor Author

We can't add it to the VS Code extension because it has to ship an old version, see curlconverter/curlconverter-vscode#1. I'll add it to the site myself, but it'll be hard because we've run out of room.

Screen Shot 2022-04-08 at 17 09 14

What if we shortened JavaScript to JS, I think that would provide enough room

src/generators/cfml.ts Outdated Show resolved Hide resolved
Co-authored-by: Boris Verkhovskiy <boris.verk@gmail.com>
@verhovsky verhovsky merged commit 4e46cea into curlconverter:master Apr 10, 2022
@verhovsky
Copy link
Member

if we shortened JavaScript to JS

That does work but I don't like that idea, sorry. JavaScript is probably the most or second most used converter, it should be the easiest to ctrl-f for and not everyone knows the abbreviation.

@verhovsky
Copy link
Member

your generator is live, thanks for working on this!

@scottsteinbeck
Copy link
Contributor Author

Awesome! Glad it's up, can you double check the website, I think the new build is not being used. It says the cfml converter is missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants