Update spvblock.py (Sourcery refactored)

[sourcery-ai]

Pull Request #620 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

• VS Code
• PyCharm

Review changes via command line

To manually merge these changes, make sure you're on the curly60e-patch-231 branch, then run:

git fetch origin sourcery/curly60e-patch-231
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

[sourcery-ai]

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	7.24 ⭐	7.24 ⭐	0.00
Method Length	92.37 🙂	92.38 🙂	0.01 👎
Working memory	9.32 🙂	9.32 🙂	0.00
Quality	62.23% 🙂	62.23% 🙂	0.00%

Other metrics	Before	After	Change
Lines	7105	7103	-2

Changed files	Quality Before	Quality After	Quality Change
pybitblock/SPV/spvblock.py	62.23% 🙂	62.23% 🙂	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
pybitblock/SPV/spvblock.py	OpenNodecreatecharge	42 ⛔	644 ⛔	26 ⛔	6.72% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py	lightningnetworkLOCALcontrol	25 😞	320 ⛔	24 ⛔	17.27% ⛔	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py	OpenNodeiniciatewithdrawal	17 🙂	396 ⛔	19 ⛔	23.83% ⛔	Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py	bitcoincoremenuLOCALcontrolAOnchainONLY	24 😞	215 ⛔	19 ⛔	25.16% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py	lnbitCreatePayWall	18 🙂	274 ⛔	20 ⛔	25.46% 😞	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!