Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ppi.py #634

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Update ppi.py #634

merged 1 commit into from
Oct 10, 2022

Conversation

SatoshiNakamotoBitcoin
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 9, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.22%.

Quality metrics Before After Change
Complexity 10.13 🙂 10.09 🙂 -0.04 👍
Method Length 138.07 😞 136.02 😞 -2.05 👍
Working memory 12.00 😞 11.95 😞 -0.05 👍
Quality 52.14% 🙂 52.36% 🙂 0.22% 👍
Other metrics Before After Change
Lines 2085 2093 8
Changed files Quality Before Quality After Quality Change
pybitblock/ppi.py 52.14% 🙂 52.36% 🙂 0.22% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pybitblock/ppi.py OpenNodecreatecharge 42 ⛔ 648 ⛔ 27 ⛔ 6.48% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/ppi.py opreturn 15 🙂 730 ⛔ 24 ⛔ 21.56% ⛔ Try splitting into smaller methods. Extract out complex expressions
pybitblock/ppi.py OpenNodeiniciatewithdrawal 17 🙂 396 ⛔ 19 ⛔ 23.83% ⛔ Try splitting into smaller methods. Extract out complex expressions
pybitblock/ppi.py lnbitCreatePayWall 18 🙂 274 ⛔ 20 ⛔ 25.46% 😞 Try splitting into smaller methods. Extract out complex expressions
pybitblock/ppi.py lnbitsLNURLw 15 🙂 274 ⛔ 19 ⛔ 28.49% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@curly60e curly60e merged commit a17e15c into curly60e:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants