Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spvblock.py #637

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Conversation

SatoshiNakamotoBitcoin
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 11, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 7.23 ⭐ 7.23 ⭐ 0.00
Method Length 92.53 πŸ™‚ 92.53 πŸ™‚ 0.00
Working memory 9.33 πŸ™‚ 9.33 πŸ™‚ 0.00
Quality 62.13% πŸ™‚ 62.13% πŸ™‚ 0.00%
Other metrics Before After Change
Lines 7187 7187 0
Changed files Quality Before Quality After Quality Change
pybitblock/SPV/spvblock.py 62.13% πŸ™‚ 62.13% πŸ™‚ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pybitblock/SPV/spvblock.py OpenNodecreatecharge 42 β›” 644 β›” 26 β›” 6.72% β›” Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py lightningnetworkLOCALcontrol 25 😞 320 β›” 24 β›” 17.27% β›” Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py OpenNodeiniciatewithdrawal 17 πŸ™‚ 396 β›” 19 β›” 23.83% β›” Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py bitcoincoremenuLOCALcontrolAOnchainONLY 24 😞 215 β›” 19 β›” 25.16% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/SPV/spvblock.py lnbitCreatePayWall 18 πŸ™‚ 274 β›” 20 β›” 25.46% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • πŸ™‚ good
  • 😞 poor
  • β›” very poor

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@curly60e curly60e merged commit fe91042 into curly60e:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants