Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #649

Merged
merged 3 commits into from
Dec 19, 2022
Merged

PR #649

merged 3 commits into from
Dec 19, 2022

Conversation

SatoshiNakamotoBitcoin
Copy link
Collaborator

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 19, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 8.20 ⭐ 8.20 ⭐ 0.00
Method Length 126.64 😞 126.57 😞 -0.07 πŸ‘
Working memory 11.18 😞 11.19 😞 0.01 πŸ‘Ž
Quality 53.47% πŸ™‚ 53.45% πŸ™‚ -0.02% πŸ‘Ž
Other metrics Before After Change
Lines 6754 6807 53
Changed files Quality Before Quality After Quality Change
pybitblock/PyBlock.py 53.47% πŸ™‚ 53.45% πŸ™‚ -0.02% πŸ‘Ž

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pybitblock/PyBlock.py lightningnetworkLOCALcontrol 30 😞 337 β›” 24 β›” 14.14% β›” Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/PyBlock.py bitcoincoremenuLOCALcontrolAOnchainONLY 25 😞 224 β›” 19 β›” 23.96% β›” Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/PyBlock.py bitcoincoremenuLOCALcontrolA 24 😞 215 β›” 18 β›” 25.92% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pybitblock/PyBlock.py counttxs 13 πŸ™‚ 431 β›” 16 β›” 29.33% 😞 Try splitting into smaller methods. Extract out complex expressions
pybitblock/PyBlock.py lightningnetworkREMOTEcontrol 18 πŸ™‚ 215 β›” 17 β›” 30.92% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • πŸ™‚ good
  • 😞 poor
  • β›” very poor

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@curly60e curly60e merged commit 527f21b into master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants