Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[money-630] Replace larssiet font with skintype-text #1875

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Conversation

cherimarie
Copy link
Contributor

@cherimarie cherimarie commented Jul 18, 2023

Related: https://github.com/curology/curology-gatsby/pull/2432

Question:
I'm surprised that .yarn/ and yarn.lock aren't git ignored. Is that intentional? Should I be committing .yarn/?

Local Storybook, showing all font styles default to 'skintype-test' instead of 'larssiet'
Screen Shot 2023-07-17 at 6 55 34 PM

Related PRs:

@linear
Copy link

linear bot commented Jul 18, 2023

MONEY-360 V6 Requirements & Set-up

Experiment Name

  • Intro Offer V6

Cohort Names

  • Control: Free Trial - 33%
  • Variant A: Provider - 33%
  • Variant B: Custom Cream- 33%

Cohorting:

  • Eligibility page landing

Testing Duration

  • Two days (in progress to validate)

User Stories

  • When landing on the eligibility page, users will see either Control, A, or B variants.
  • Across all experiment arms, users are inputting their state and age to check eligibility - the same experience as the control
  • After clicking "Continue" A and B variants go into Intro Offers V2 flow, depending what will be the latest working option

public/stylesheet.css Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@ const PRIMARY_FONTS = {
headerFont:
"'nocturno', Georgia, TimesNewRoman, 'Times New Roman', Times, Baskerville, serif",
baseFont:
"'larssiet', 'Avant Garde', Avantgarde, 'Century Gothic', CenturyGothic, AppleGothic, Verdana, sans-serif",
"'skintype-text', 'Avant Garde', Avantgarde, 'Century Gothic', CenturyGothic, AppleGothic, Verdana, sans-serif",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, Avant Garde/avantgarde font doesn't seem to be loading. If I inspect source on the live site right now and remove larssiet from the stack, I get Century Gothic. This could be an environment-specific issue, but there's also no other reference to Avant Garde here, including any import. Should we do something about that?

@cherimarie cherimarie changed the title [money-360] Replace larssiet font with skintype-text [money-630] Replace larssiet font with skintype-text Jul 18, 2023
@linear
Copy link

linear bot commented Jul 18, 2023

MONEY-630 Switch font from Larsseit to Skintype

✏️ User Story / Description

All pages currently using Larsseit need to switch to Skintype

Acceptance Criteria

  • Check all surface areas (pair with jess.cohen for approval)
    • sign up flow
    • Rx PDPs
    • reviews
    • contact us
    • patient dashboard
      • home
      • shipments
      • messages
      • manage subscription
      • orders
      • progress
      • treatment plan
      • customize your box
      • check-in
      • cancellation
      • resubscribe

📌 Resources

🙋 Open questions

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 18, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8cd58d9
Status: ✅  Deploy successful!
Preview URL: https://eb325b41.radiance-ui.pages.dev
Branch Preview URL: https://ca-money-360.radiance-ui.pages.dev

View logs

@socket-security
Copy link

socket-security bot commented Jul 18, 2023

Copy link
Contributor

@ZeMunchkin ZeMunchkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. There's some CI failures, but assuming those get worked out I don't see anything blocking.

When we tried adding a new font for admin last year, I remember also needing to add it to PocketDerm font files for them to take effect: https://github.com/curology/PocketDerm/pull/18868

I'm not sure if that's also the case for patient-facing, but looking through things in PocketDerm, Larssiet is part of the fonts in the layout. You're probably all over that since this piece would need to be changed first, but wanted to point that in out just in case :) Those should be updated when the radiance version gets bumped.
https://github.com/curology/PocketDerm/blob/master/resources/views/app/layout/curology/fonts.blade.php

@cherimarie
Copy link
Contributor Author

@ZeMunchkin great callout, and yep, I'm on it! https://github.com/curology/PocketDerm/pull/21008

@cherimarie cherimarie merged commit 13387ff into master Jul 27, 2023
7 checks passed
@cherimarie cherimarie deleted the ca-money-360 branch July 27, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants