-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[money-630] Replace larssiet font with skintype-text #1875
Conversation
MONEY-360 V6 Requirements & Set-up
Experiment Name
Cohort Names
Cohorting:
Testing Duration
User Stories
|
src/constants/fonts/primary.ts
Outdated
@@ -2,7 +2,7 @@ const PRIMARY_FONTS = { | |||
headerFont: | |||
"'nocturno', Georgia, TimesNewRoman, 'Times New Roman', Times, Baskerville, serif", | |||
baseFont: | |||
"'larssiet', 'Avant Garde', Avantgarde, 'Century Gothic', CenturyGothic, AppleGothic, Verdana, sans-serif", | |||
"'skintype-text', 'Avant Garde', Avantgarde, 'Century Gothic', CenturyGothic, AppleGothic, Verdana, sans-serif", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, Avant Garde/avantgarde font doesn't seem to be loading. If I inspect source on the live site right now and remove larssiet from the stack, I get Century Gothic. This could be an environment-specific issue, but there's also no other reference to Avant Garde here, including any import. Should we do something about that?
MONEY-630 Switch font from Larsseit to Skintype
✏️ User Story / Description All pages currently using Larsseit need to switch to Skintype ✅ Acceptance Criteria
📌 Resources 🙋 Open questions |
Deploying with
|
Latest commit: |
8cd58d9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://eb325b41.radiance-ui.pages.dev |
Branch Preview URL: | https://ca-money-360.radiance-ui.pages.dev |
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me. There's some CI failures, but assuming those get worked out I don't see anything blocking.
When we tried adding a new font for admin last year, I remember also needing to add it to PocketDerm font files for them to take effect: https://github.com/curology/PocketDerm/pull/18868
I'm not sure if that's also the case for patient-facing, but looking through things in PocketDerm, Larssiet is part of the fonts in the layout. You're probably all over that since this piece would need to be changed first, but wanted to point that in out just in case :) Those should be updated when the radiance version gets bumped.
https://github.com/curology/PocketDerm/blob/master/resources/views/app/layout/curology/fonts.blade.php
@ZeMunchkin great callout, and yep, I'm on it! https://github.com/curology/PocketDerm/pull/21008 |
Related: https://github.com/curology/curology-gatsby/pull/2432
Question:
I'm surprised that
.yarn/
andyarn.lock
aren't git ignored. Is that intentional? Should I be committing.yarn/
?Local Storybook, showing all font styles default to 'skintype-test' instead of 'larssiet'
![Screen Shot 2023-07-17 at 6 55 34 PM](https://private-user-images.githubusercontent.com/2523812/254117288-61e091d6-8e14-4de9-887f-fdf48d2e77a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjIxMjc3NjcsIm5iZiI6MTcyMjEyNzQ2NywicGF0aCI6Ii8yNTIzODEyLzI1NDExNzI4OC02MWUwOTFkNi04ZTE0LTRkZTktODg3Zi1mZGY0OGQyZTc3YTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcyOCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MjhUMDA0NDI3WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTk4YmI5N2VmNWE3MmJkZDI0Njk1NWE3ZGVmZTNiNTUyZjMxYWM4YzM5M2JlMDZmNjU2ODRhNGJhNDA3OGQ3MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.mAiJWt_wWPkOXVMi44KjZZP1u3Evd5Gtu3LEqzwNJOw)
Related PRs: