Fix Dark Circles SVG fill #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ff8e346
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5ab7d5d.radiance-ui.pages.dev |
| Branch Preview URL: | https://dark-circles-svg-fill.radiance-ui.pages.dev |
mdhamija94
force-pushed
the
dark-circles-svg-fill
branch
from
82396d6
to
8124033
Compare
elysiagabe
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Pulled the branch down locally and am looking at the src/svgs/glyphs/dark-circles-glyph.svg file. You'll want to change the fill to currentColor there as well and add a <title>! See docs
mdhamija94
force-pushed
the
dark-circles-svg-fill
branch
from
8124033
to
ff8e346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On initial implementation of the Dark Circles SVG, I missed updating the fill for two out of three paths to be configurable to the prop color that is passed. This PR corrects that.