Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and release process #30

Closed
2 tasks
agoldis opened this issue Apr 7, 2023 · 11 comments · Fixed by #33
Closed
2 tasks

Build and release process #30

agoldis opened this issue Apr 7, 2023 · 11 comments · Fixed by #33
Assignees

Comments

@agoldis
Copy link
Contributor

agoldis commented Apr 7, 2023

  • Establish release and build process (you can copy from cypress-cloud or find a better solution)
    • Generate Changelog
    • Update version
    • Create tag and github release
    • Prepare dist directory for publishing on npm (you can use verdaccio to publish locally)
    • The published package should contain:
      • TS definitions
      • Node 14 compatible packages
      • Have a CJS format
  • Update the documentation with the release and publishing process
@vCaisim
Copy link
Contributor

vCaisim commented Apr 10, 2023

@agoldis the package name should be cypress-debugger or @currents/cypress-debugger?

@agoldis
Copy link
Contributor Author

agoldis commented Apr 10, 2023 via email

@agoldis
Copy link
Contributor Author

agoldis commented Apr 11, 2023

@vCaisim how is it going?

@vCaisim
Copy link
Contributor

vCaisim commented Apr 11, 2023

I am getting an error while trying to install the package in a test project using the local repository with Verdaccio.

Image

@vCaisim
Copy link
Contributor

vCaisim commented Apr 11, 2023

@agoldis can you take a look? I published the package to the local registry, getting the error while installing it. It seems that it looks for an internal package in the registry. I thought that it may be related to the usage of internal packages. I searched for solutions, but without success. Maybe I am missing smth.

@agoldis
Copy link
Contributor Author

agoldis commented Apr 11, 2023

@vCaisim please communicate - what did you try? Do you need any help with proceeding? Maybe you need to publish the package @currents/cypress-debugger-plugin.
I am less available than usual, when you're stuck please post on Slack - myself, Richard or Vitalli can help

@vCaisim
Copy link
Contributor

vCaisim commented Apr 11, 2023

I wanted to try to solve the issue myself. I also asked Vitalii on Slack, but he doesn't have experience with Verdaccio.

@vCaisim
Copy link
Contributor

vCaisim commented Apr 11, 2023

I tried to follow the steps from README for publishing the package locally - https://github.com/currents-dev/cypress-debugger/pull/33/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R148.
I used verdaccio and was able to publish the package following the steps. I tried to install the package, to test it and was getting the issue above.

@vCaisim
Copy link
Contributor

vCaisim commented Apr 11, 2023

@currents/cypress-debugger-plugin is an internal package, I don't think that is should be published

@vCaisim
Copy link
Contributor

vCaisim commented Apr 11, 2023

@agoldis, I set Changesets for releases and updated the CONTRIBUTE.md. I was able to generate CHANGELOG.md files for every package but was unable to test the publishing using the local registry.

I tried to set the local registry using the publishConfig.registry approach, by setting the registry via the .npmrc, npm_config_registry env var and using npm config set registry

Image

Please tell me your opinion on Changesets. I will continue to try to fix the issue tomorrow

@vCaisim
Copy link
Contributor

vCaisim commented Apr 12, 2023

Update:

  • the cypress-debugger cannot be published to Verdaccio because it has npm as an uplink.
  • I tried to publish packages from a test monorepo to Verdaccio using Changesets and succeeded.
  • I set the private field to true for @currents/cypress-debugger-support and @currents/cypress-debugger-plugin since they should be used only inside the cypress-debugger

There is a way to automate the release process - https://github.com/changesets/changesets/blob/main/docs/automating-changesets.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants