Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading in the UI #19

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Uploading in the UI #19

merged 8 commits into from
Mar 23, 2023

Conversation

vCaisim
Copy link
Contributor

@vCaisim vCaisim commented Mar 21, 2023

Added the option to upload the data via file upload and fetching:

  • the upload can be performed by clicking on the text or dragging a file in the area
  • the data can be fetched by specifying a valid URL in the page payload query param

image

@agoldis, the error handling is made using console.error and alert. Is this implementation enough for now, can I move to other tasks?

@vCaisim vCaisim requested a review from agoldis March 21, 2023 16:27
@agoldis agoldis marked this pull request as ready for review March 22, 2023 04:59
@agoldis
Copy link
Contributor

agoldis commented Mar 22, 2023

@agoldis
Copy link
Contributor

agoldis commented Mar 22, 2023

@vCaisim would be much easier if you could records a gif / video with a demo

@agoldis
Copy link
Contributor

agoldis commented Mar 22, 2023

@vCaisim
Copy link
Contributor Author

vCaisim commented Mar 22, 2023

@agoldis
Copy link
Contributor

agoldis commented Mar 23, 2023

re: loading via URL

How are you not getting the CORS error?
currents-2023-03-23-00 58 34@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants