New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using deprecated Talon settings api #2165

Closed

pokey opened this issue Jan 7, 2024 · 0 comments · Fixed by #2166

Member

pokey commented Jan 7, 2024 •

edited

It's causing a talon deprecation warning on latest beta.

Instead of foo = Setting(...); foo.get(), we need to use settings.get("user.foo")

The text was updated successfully, but these errors were encountered:

pokey mentioned this issue

Stop using deprecated talon setting support #2166

Merged

1 task

github-merge-queue bot pushed a commit that referenced this issue


          Stop using deprecated talon setting support (#2166)

3aff2da

- Fixes #2165

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

AndreasArvidsson closed this as completed in #2166

cursorless-bot pushed a commit to cursorless-dev/cursorless-talon that referenced this issue


          Stop using deprecated talon setting support (#2166)

cbff4be

- Fixes cursorless-dev/cursorless#2165

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

cursorless-bot pushed a commit that referenced this issue


          Stop using deprecated talon setting support (#2166)

2a1dafc

- Fixes #2165

## Checklist

- [-] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [x] I have not broken the cheatsheet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment