Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"take inside" Does not work when part of the string is already selected #882

Closed
bjaspan opened this issue Jul 19, 2022 · 2 comments · Fixed by #888
Closed

"take inside" Does not work when part of the string is already selected #882

bjaspan opened this issue Jul 19, 2022 · 2 comments · Fixed by #888
Assignees

Comments

@bjaspan
Copy link
Contributor

bjaspan commented Jul 19, 2022

Suppose I have the string "hello world" With a dot on the w. If I say take whale, the word world is selected. If I then say take inside, the command is recognized but nothing happens. If I say go left so that now nothing is selected then say take inside, both hello and world are selected.

@pokey
Copy link
Member

pokey commented Jul 19, 2022

Believed to be caused by making non-empty selections non-weak in #836. See

return selection.selection.isEmpty
? new WeakTarget(parameters)
: new TokenTarget(parameters);

@pokey pokey transferred this issue from cursorless-dev/cursorless-talon Jul 19, 2022
@AndreasArvidsson
Copy link
Member

It is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants