You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rename WeakTarget to UntypedRangeTarget and add a constructor argument hasExplicitRange
Rename isWeak to hasExplicitScopeType, but need to negate all references to it as it is the opposite
Check for other references to the term "weak" to make sure we're not missing something
Introduce hasExplicitRange as attribute on Target
For eg ScopeTypeTarget, hasExplicitScopeType = true and hasExplicitRange = true
For each target in spreadsheet, return the proposed type of target as indicated in the Proposed type row
For each action / modifier in spreadsheet, depending on the value of column Checks for implicit, check either !hasExplicitRange or !hasExplicitScopeType
We're not sure whether the following is a good idea:
cursorless/src/processTargets/marks/CursorStage.ts
Lines 21 to 23 in b639e42
Pros
Cons
The solution
WeakTarget
toUntypedRangeTarget
and add a constructor argumenthasExplicitRange
isWeak
tohasExplicitScopeType
, but need to negate all references to it as it is the oppositehasExplicitRange
as attribute onTarget
ScopeTypeTarget
,hasExplicitScopeType = true
andhasExplicitRange = true
!hasExplicitRange
or!hasExplicitScopeType
The text was updated successfully, but these errors were encountered: