Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack to work around microsoft/vscode#178241 #1515

Merged
merged 5 commits into from
Jun 15, 2023
Merged

Hack to work around microsoft/vscode#178241 #1515

merged 5 commits into from
Jun 15, 2023

Conversation

pokey
Copy link
Member

@pokey pokey commented Jun 6, 2023 •
edited
Loading

Checklist

  • Fails when test case legitimately fails
  • Retries when test case fails with "codewindow unresponsive"
  • Succeeds when test case succeeds
  • I have added tests
  • I have updated the docs and cheatsheet
  • I have not broken the cheatsheet

@pokey pokey force-pushed the pokey/hack-to-work-around-microsoftvscode178241 branch 10 times, most recently from 487b392 to cd13a2a Compare June 7, 2023 12:53
@pokey pokey added the to discuss Plan to discuss at meet-up label Jun 13, 2023
@pokey pokey force-pushed the pokey/hack-to-work-around-microsoftvscode178241 branch from cd13a2a to 2ae38ab Compare June 15, 2023 13:12
@pokey pokey marked this pull request as ready for review June 15, 2023 14:54
@pokey pokey enabled auto-merge June 15, 2023 14:54
@pokey
Copy link
Member Author

pokey commented Jun 15, 2023

Yep seems that the anonymous function wrapper thing removed the undefined line 👍. Not sure how necessary our console log statement is when things pass, but prob not harmful 🤷‍♂️. Could maybe suppress it when it's equal to 0, but not sure that's better tbh

@pokey pokey removed the to discuss Plan to discuss at meet-up label Jun 15, 2023
@pokey pokey marked this pull request as draft June 15, 2023 16:08
auto-merge was automatically disabled June 15, 2023 16:08

Pull request was converted to draft

@pokey pokey force-pushed the pokey/hack-to-work-around-microsoftvscode178241 branch from 9793e6e to 6044cd0 Compare June 15, 2023 16:13
@pokey pokey marked this pull request as ready for review June 15, 2023 16:13
@pokey
Copy link
Member Author

pokey commented Jun 15, 2023

i just disabled it for windows instead of removing it entirely, because there was a bit of infrastructure to make the crash dump artifacts work which it didn't seem worth removing

@pokey pokey enabled auto-merge June 15, 2023 16:14
@pokey pokey added this pull request to the merge queue Jun 15, 2023
Merged via the queue into main with commit 85a50bb Jun 15, 2023
15 checks passed
@pokey pokey deleted the pokey/hack-to-work-around-microsoftvscode178241 branch June 15, 2023 19:53
@pokey pokey mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasArvidsson AndreasArvidsson AndreasArvidsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Work around nondeterministic windows CI test failures
2 participants
@pokey @AndreasArvidsson