Finish adding scope support facet skeletons #2370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
changed the title
pokey
commented
May 30, 2024
| import { xmlScopeSupport } from "./xml"; | ||
| import { yamlScopeSupport } from "./yaml"; | ||
|
|
||
| export const languageScopeSupport: Record< |
There was a problem hiding this comment.
I changed this to a dictionary so I could iterate the keys in the scope test coverage check
pokey
commented
May 30, 2024
| @@ -35,7 +35,7 @@ export async function launchVscodeAndRunTests(extensionTestsPath: string) { | |||
| // NB: We include the exact version here instead of in `test.yml` so that | |||
| // we don't have to update the branch protection rules every time we bump | |||
| // the legacy VSCode version. | |||
| const vscodeVersion = useLegacyVscode ? "1.75.1" : "stable"; | |||
| const vscodeVersion = useLegacyVscode ? "1.79.2" : "stable"; | |||
There was a problem hiding this comment.
This is the version that introduced jsonl language id (see release notes). Because this PR introduces our first jsonl tests, it fails on older VSCode versions. Given this version was released a year ago, we can make this our legacy version per our policy
Merged
AndreasArvidsson
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist