-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated surrounding pair scope handler #2457
base: main
Are you sure you want to change the base?
Conversation
…ev/cursorless into surroundingPairScopeHandler
I would argue that this is not a matching delimiter pair at all. It is the scope type string which we have no spoken form for at the moment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed everything, but left a few comments
data/fixtures/recorded/surroundingPair/textual/changePairBackward.yml
Outdated
Show resolved
Hide resolved
...ssTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/SurroundingPairScopeHandler.ts
Outdated
Show resolved
Hide resolved
...ssTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/SurroundingPairScopeHandler.ts
Outdated
Show resolved
Hide resolved
...ssTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/SurroundingPairScopeHandler.ts
Show resolved
Hide resolved
...ssTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/SurroundingPairScopeHandler.ts
Outdated
Show resolved
Hide resolved
...ssTargets/modifiers/scopeHandlers/SurroundingPairScopeHandler/SurroundingPairScopeHandler.ts
Show resolved
Hide resolved
This is really interesting "if the file is over 30MB or over 300k lines, we consider it to be a very large file and proceed to turn off very many features, including tokenization, word wrapping, indent guides, anything that would consume additional memory, etc." That means that Cursorless can never encounter a file with over three hundred thousand lines. I just did a test with the surrounding pair regex on a file with just below three hundred thousand lines and that clocked in at |
Fixes #2316
Checklist
@disqualifyDelimiter
for all languages