-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make arguments to engine optional #2477
Conversation
update from meet-up re null tree-sitter:
goal for all this stuff is to allow undefined components to pass into engine, and contain all resulting null checks to |
ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow this PR does a lot. I started in for a quick review but there's too much going on to easily see the picture. I would be tempted to split it into 4 PRs, but how about as a compromise let's just split it into 2:
- CommandServerApi / HatTokenMap
- LanguageDefinitions / TreeSitter
I think that is a nice split point
See also the commit I just pushed, and comments below
@@ -27,7 +27,7 @@ export class CommandHistory implements CommandRunnerDecorator { | |||
constructor( | |||
private ide: IDE, | |||
private storage: CommandHistoryStorage, | |||
private commandServerApi: CommandServerApi | null, | |||
private commandServerApi: CommandServerApi | undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is no longer ever undefined right?
private commandServerApi: CommandServerApi | undefined, | |
private commandServerApi: CommandServerApi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not. This is constructed in the extension file and does not get the disabled default implementation from the engine
Ok this pull request has now been stripped off the Tree sitter stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good with one minor comment!
Checklist