Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace path with pathe #2481

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Replace path with pathe #2481

merged 8 commits into from
Jul 11, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 9, 2024

This is a simple way of getting rid of node path references in common and engine. I thought it best to also replace it in vscode so we don't have different implementations for path in the bundle. I guess for things like running tests and ours setup scrips then just using node path is probably fine? I could go either way.

https://www.npmjs.com/package/pathe

Checklist

  • [/] I have added tests
  • [/] I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're on the same page that any references to path in the engine are a smell, but this is a fine way forward for now

@AndreasArvidsson
Copy link
Member Author

Totally in agreements there

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit 57047bf Jul 11, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the pathe branch July 11, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants