Added Tree sitter provider #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| languageQueryPath: string, | ||
| ide: IDE, | ||
| provider: RawTreeSitterQueryProvider, | ||
| languageQueryName: string, |
There was a problem hiding this comment.
The reason for switching from path to name is that if we have a non file system implementation of the language provider, path is irrelevant. I think every definition name(scm filename) should just be unique and in which folder they are located doesn't really matter.
pokey
approved these changes
Jul 12, 2024
|
|
||
| /** | ||
| * Sentinel value to indicate that a language doesn't have | ||
| * a new-style query definition file | ||
| */ | ||
| const LANGUAGE_UNDEFINED = Symbol("LANGUAGE_UNDEFINED"); | ||
|
|
||
| export interface LanguageDefinitions { |
There was a problem hiding this comment.
I removed the lifecycle methods from this interface (init and dispose). I don't think interfaces should expose lifecycle methods. Clients of an interface shouldn't be responsible for the lifecycle of any given instance; that is the job of whoever constructs the actual class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist