-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursorless everywhere in Talon #2503
Conversation
@pokey Updated. We have two ongoing discussions that we need to resolve then we can merge |
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's ship it!
class EditorChanges(TypedDict): | ||
text: str | ||
changes: list[EditorChange] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added docstrings. Still not in love but at least it makes it clearer what's happening
## Oddities and todos - [ ] Talon requires a javascript file to have a Talon(or another package?) import before any other code. Right now I do that in my [`esbuild.sh`](https://github.com/cursorless-dev/cursorless/blob/100f7706553fd24ce3ccbec2d1ec30c20e7f0a3f/packages/cursorless-talon-js/esbuild.sh#L20-L22) script. This does not support esbuild watch. - The solution here is for Talon to support mjs file endings - [x] Restore num selections check for windows: [`cursorless_everywhere_talon_win.py`](https://github.com/cursorless-dev/cursorless/blob/824735f58e58ea3ca5bfb2448df801a4e7f28b1c/cursorless-everywhere-talon/cursorless_everywhere_talon_win.py#L49-L50) once Talon converts from js to py correctly - [x] Is there any point in outputting source maps to Talon? - [x] If easy, let's run in CI on all platforms ## Information * https://bellard.org/quickjs/ ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Pokey Rule <755842+pokey@users.noreply.github.com>
Oddities and todos
esbuild.sh
script. This does not support esbuild watch.cursorless_everywhere_talon_win.py
once Talon converts from js to py correctlyInformation
Checklist