Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple dices. #1

Merged
merged 7 commits into from
Dec 22, 2022
Merged

Multiple dices. #1

merged 7 commits into from
Dec 22, 2022

Conversation

cusma
Copy link
Owner

@cusma cusma commented Dec 19, 2022

This PR adds the possibility of rolling multiple dices in one round, guaranteeing "safe randomness" for all the dices.

  • New dApp (PyTeal, TEAL, JSON);
  • Updated CLI;
  • Updated README.md (includes dApp state diagram).

Nit `README.md`

Nit `README.md`

Nit `README.md`
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
algodices_dapp.py Show resolved Hide resolved
algodices_dapp.py Show resolved Hide resolved
algodices_dapp.py Show resolved Hide resolved
cusma and others added 3 commits December 20, 2022 18:27
Co-authored-by: Fabrice Benhamouda <fbenhamo102@gmail.com>
Copy link
Collaborator

@fabrice102 fabrice102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
Note: I did not do a full review.

@cusma
Copy link
Owner Author

cusma commented Dec 22, 2022

It looks good to me.
Note: I did not do a full review.

Thanks Fabrice, can you resolve all the conversations (if ok) and approve so that I can merge?

@cusma cusma merged commit 2eca745 into main Dec 22, 2022
@cusma cusma deleted the multiple_dices branch December 22, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants