dynamic color options #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuuji
reviewed
Sep 5, 2018
| @@ -25,7 +25,7 @@ class ButtonCard extends LitElement { | |||
|
|
|||
|
|
|||
| getFontColorBasedOnBackgroundColor(backgroundColor) { | |||
| const parsedBackgroundColor = backgroundColor.match(/^rgb\s*\(\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d+)\s*\)$/i); | |||
| const parsedBackgroundColor = backgroundColor.match(/^rgb\s*\(\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d+)\s*\)$/i) ? backgroundColor.match(/^rgb\s*\(\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d+)\s*\)$/i) : this.hexToRgb(backgroundColor.substring(1)); | |||
There was a problem hiding this comment.
I'd do
const parsedRgbColor= backgroundColor.match(/^rgb\s*\(\s*(\d+)\s*,\s*(\d+)\s*,\s*(\d+)\s*\)$/i);
const parsedBackgroundColor = parsedRgbColor ? parsedRgbColor : this.hexToRgb(backgroundColor.substring(1));That way you avoid going through the regex twice. It's just a simple regex but if you have 20 buttons, it adds up.
|
That's awesome! Thanks a lot @simo878 Let me test that tonight, I made one suggestion but it's really not a big deal.
Yeah I haven't scratched my head too hard about the css var yet. These are only evaluated by CSS / your browser. It looks like it will involve some wacky things to make that work. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is more of a feature request, my coding is quite limited and this is my first ever PR so sorry if its not correct.
basicly this fuctionality adds the ability to set hex color option in ui-lovelace like this :
color: "#1affa3"I assumed this would also work for setting "var(--primary-color)" but it does not (only works for direct hex value) and that is the limit of my ability.
the reason for this request is so that button colors can bet set to theme variables and thus become dynamic with theme change.
Thanks.