Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible conflict with DarkSky Weather Card #9

Closed
SeLLeRoNe opened this issue Oct 6, 2019 · 4 comments
Closed

Possible conflict with DarkSky Weather Card #9

SeLLeRoNe opened this issue Oct 6, 2019 · 4 comments

Comments

@SeLLeRoNe
Copy link

Hi there,
I am not really sure there is something that can be done on this card to fix the issue, I have a feeling that is more up to the DarkSky Weather Card guys, but would you please be able to look on this thread since my message here?
https://community.home-assistant.io/t/custom-dark-sky-animated-weather-card/59816/1170?u=sellerone

Long story short, the darksky-weather-card stop working with this error:
Uncaught SyntaxError: Identifier 'LitElement' has already been declared
at dark-sky-weather-card.js:1

This is happening only when i load (not use, simply load the resource in the configuration) the button-entity-row card

I am not a developer so I am not really capable of debug it more myself, but I am available if you need further informations (if that is something you need fix on your end).

Thanks
Andrea

@SeLLeRoNe SeLLeRoNe changed the title Possible conflict with DarkSkye Weather Carfd Possible conflict with DarkSkye Weather Card Oct 6, 2019
@jcwillox
Copy link
Contributor

Hey, @SeLLeRoNe is this still an issue? I just tried running dark-sky-weather-card and button-entity-row and couldn't reproduce the error? Is this the same repo you downloaded it from? https://github.com/iammexx/home-assistant-config/tree/master/ui/darksky. Nevertheless, it's likely an issue with that card, as many other cards using LitElement define it the same way button-entity-row does without any conflicting issues. You should probably open an issue there, side note looking at their code it's probably because LitElement is defined as a constant and they're trying to assign it a value.

@SeLLeRoNe SeLLeRoNe changed the title Possible conflict with DarkSkye Weather Card Possible conflict with DarkSky Weather Card Oct 11, 2019
@jcwillox
Copy link
Contributor

@SeLLeRoNe can you check you have defined dark-sky-weather-card with type: module? When changing to type: js I am able to reproduce your error, but with type: module it works fine.

@SeLLeRoNe
Copy link
Author

Wow that actually fixed it!

I have been using that card for months without a problem on type js, never noticed it has to be type module!

Thank you very much for even just wasting time on trying to replicate it!

@jcwillox
Copy link
Contributor

That's odd, but glad it's fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants