Home Assistant 2022.11 compatibility #47

ov1d1u · 2022-11-03T06:56:15Z

Home Assistant 2022.11 added borders around cards. This PR comes with the option to hide them.

piitaya · 2022-11-03T09:58:22Z

I think we can also edit the readme to add the new keep option.

ov1d1u · 2022-11-03T10:11:03Z

@piitaya Added, thanks for pointing it out!

Getslow6 · 2022-11-04T07:19:03Z

@piitaya or @ov1d1u, do you know if its possible to get the resulting stack-in-card.js file (or contents in a pastebin?) without waiting for the new release? I tried making the edits in my local file based on your source edits, but the release pipeline obfuscates the code and I'm not that experienced in javascript to be able to edit it myself 😅

ov1d1u · 2022-11-04T07:29:06Z

@Getslow6 I added a compiled .js file to my repository, in the releases section, you can download it from https://github.com/ov1d1u/stack-in-card/releases/download/0.2.1/stack-in-card.js

Rudd-O · 2022-11-05T13:05:22Z

Can this please be merged? Thansk.

Rudd-O · 2022-11-05T13:07:22Z

Uh oh the documentation README has not been updated!

correctomundo79 · 2022-11-07T15:01:22Z

@Getslow6 I added a compiled .js file to my repository, in the releases section, you can download it from https://github.com/ov1d1u/stack-in-card/releases/download/0.2.1/stack-in-card.js

Thanks for this! I'm just wondering what the exact syntax would be to prevent borders on child cards. I assume:

type: custom:stack-in-card
mode: vertical
keep:
  - border: false
cards:

but that doesn't seem to work?

Getslow6 · 2022-11-07T15:13:58Z

@Getslow6 I added a compiled .js file to my repository, in the releases section, you can download it from https://github.com/ov1d1u/stack-in-card/releases/download/0.2.1/stack-in-card.js

Thanks for this! I'm just wondering what the exact syntax would be to prevent borders on child cards. I assume:

type: custom:stack-in-card mode: vertical keep:

border: false
cards:

but that doesn't seem to work?

Try removing the cache of your browser (not just reload). You don't need the keep section, so:

type: custom:stack-in-card
mode: vertical
cards:

correctomundo79 · 2022-11-07T16:02:09Z

Try removing the cache of your browser (not just reload). You don't need the keep section, so:
type: custom:stack-in-card
mode: vertical
cards:

Nope, tried that already, but no difference. Thanks anyway.

strikeir13 · 2022-11-09T14:52:42Z

@Getslow6 I added a compiled .js file to my repository, in the releases section, you can download it from https://github.com/ov1d1u/stack-in-card/releases/download/0.2.1/stack-in-card.js

I overwrote the existing stack-in-card.js file with this one, cleared my browser cache, and tried many combinations of keep: but nothing worked. Are there any other steps required to make this work?

ronaldheft · 2022-11-09T14:57:07Z

@strikeir13 Are you using HACS? Do you have a *.js.gz file in the folder?

If so, you need to delete that, as HACS will serve up the gzipped version. After deleting the file, clear your cache again.

strikeir13 · 2022-11-09T15:22:31Z

@strikeir13 Are you using HACS? Do you have a *.js.gz file in the folder?

If so, you need to delete that, as HACS will serve up the gzipped version. After deleting the file, clear your cache again.

That did it! Thank you!

Rudd-O · 2022-11-10T00:41:14Z

What's preventing this from getting merged? Can I be added to the reviewers list? Thanks.

amjidkhan · 2022-11-11T17:39:32Z

Any idea when this will be merged?

amjidkhan · 2022-11-11T17:47:21Z

https://github.com/ov1d1u/stack-in-card/releases/download/0.2.1/stack-in-card.js

Can you advise a novice user the steps?

almighty059 · 2022-11-12T16:53:21Z

@Getslow6 I uploaded your compiled .js file from your repository and it works to remove the borders but can I use the keep: feature to keep the border? It doesn't seem to be working although I'be never really had any luck using that feature. Thanks.

Rudd-O

Needs README changes please. Other than that you should have a green light from me.

ov1d1u · 2022-11-14T18:52:38Z

@Rudd-O I also updated the README.md file a while ago to reflect the new border options, is there something I have missed?

almighty059 · 2022-11-14T23:12:21Z

@ov1d1u the border: feature is working for me but when I try to use the keep: feature and set the border or something else to true it does not work. I don't know if I'm using the wrong syntax or exactly what wrong but I can't get a value of true to work for anything within the keep: feature. The README.md file has as long as I known never had an actual example of it being used. The only example that it has is of how to use the --keep-background: feature for a specific entity. Could you also possibly add that to the README.md file and double check to see if it's actually working.? Thanks.

…tyles

ov1d1u · 2022-11-15T10:26:48Z

@almighty059 I think you misunderstood the documentation a bit. The example given here regarding how to use --keep-background only applies to a card of type custom:button-card. The right way to use the keep object is somethink like this:

type: custom:stack-in-card
title: My Stack In Card
mode: vertical
keep:
  border: true
cards:
  - type: horizontal-stack
    cards:
      - type: button
        entity: sun.sun
      - type: button
        entity: sun.sun
  - type: vertical-stack
    cards:
      - type: entities
        entities:
          - sun.sun

Anyway, I added support for the --keep-border css variable, to use it you should do something like:

type: custom:stack-in-card
title: My Stack In Card
mode: vertical
cards:
  - type: horizontal-stack
    cards:
      - type: custom:button-card
        entity: sun.sun
        styles:
          card:
            - '--keep-border': 'true'
      - type: button
        entity: sun.sun
  - type: vertical-stack
    cards:
      - type: entities
        entities:
          - sun.sun

I also updated the documentation to reflect the usage of the keep object, even if it goes a little beyond the scope of this PR.

almighty059 · 2022-11-16T10:34:20Z

@ov1d1u thanks for the reply. Just to clarify, I was referring to the code in your keep: example (outside the stack), not --keep-background (inside the stack). It has never worked for me because I never knew the correct way to implement it. I've tried various ways by changing where I put it, how I indented it, putting a - before it, putting a ; after it, etc. but nothing ever worked. After seeing your example, I finally know the correct way to use it and now it works. That's also what I was referring to when I said that there is no example of how it's used (outside of the stack) in the README file. The only example shown is --keep-background which is for when it's used inside the stack. Thanks again for the help and I apologize for straying outside the scope of the PR.

ildar170975 · 2022-11-30T01:16:48Z

This fix does not solve problems with a case "a stack inside another stack"- see #51

ViktuK359 · 2022-12-08T13:16:05Z

What am I doing wrong, I installed "custom:stack-in-card" it through HACS and gives it out when filling out the card
Custom element doesn't exist: stack-in-card

bokub · 2023-03-01T07:21:50Z

It looks like this PR will never be merged, so I decided to remove the borders myself with some CSS, and it's actually very easy, you just need to install the Mod Card, and add the following to every stacked card:

type: custom:stack-in-card
+ card_mod:
+   style: 'ha-card {--ha-card-border-width: 0}'

Before

After

type: custom:stack-in-card 
cards:
  ...
ㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤㅤ
ㅤ

type: custom:stack-in-card
card_mod:
  style: 'ha-card {--ha-card-border-width: 0}'
cards:
  ...

Rudd-O · 2023-03-01T19:03:44Z

Why will this PR not get merged? It should!

bokub · 2023-03-02T11:06:33Z

Why will this PR not get merged? It should!

I'm just guessing based on the fact that this repo's last commit was in 2020

Rudd-O · 2023-03-03T19:06:08Z

Does anyone know what happened to the maintainer of this project?

ncd7 · 2023-09-10T22:21:57Z

Any news on probability of this getting merged?

Kalitsune · 2024-01-02T11:20:57Z

There's no maintainer unfortunately, the project isn't maintained since 2020 according to the README.md :(

The community is still pretty active with this card thought and there's a few PR fixing the principal bugs so if someone want to make a custom repo to do the aggregation of all of these changes I think it would be pretty useful and would not require a lot of time and efforts

ildar170975 · 2024-01-30T19:24:35Z

@ov1d1u
Hi.
I do see --keep-border working in this config (similar to your example):

  - type: custom:stack-in-card
    cards:
      - type: custom:button-card
        entity: sun.sun
        styles:
          card:
            - '--keep-border': 'true'
      - type: custom:button-card
        entity: sun.sun

The upper button definitely has own border:

But I cannot use --keep-border with other cards like standard Entity, History-graph:

  - type: custom:stack-in-card
    cards:
      - type: entity
        entity: sun.sun
        card_mod:
          style: |
            ha-card {
              --keep-border: true;
            }
      - type: entity
        entity: sun.sun

as well as with

--keep-border: 'true';

Does it mean that your added --keep-border may only be used with a custom:button-card?

The earlier added --keep-background does work with standard cards as well.

Home Assistant 2022.11 compatibility

87bd192

piitaya mentioned this pull request Nov 3, 2022

Remove card border #48

Closed

Add border option to the relevant documentation for the keep object

7221ff2

scharmach mentioned this pull request Nov 3, 2022

Borders are showing up from HA Core version 2022.11 #46

Open

bedson87 mentioned this pull request Nov 5, 2022

Glitches with in_card and Home Assistant 2022.11 jcwillox/lovelace-canary#21

Closed

Rudd-O suggested changes Nov 14, 2022

View reviewed changes

Rudd-O approved these changes Nov 15, 2022

View reviewed changes

ov1d1u added 2 commits November 15, 2022 12:10

Respect --keep-border css variable when added to custom button card s…

e0b2a19

…tyles

Update README.md to add an example with using the keep object

26972f8

piitaya mentioned this pull request Nov 25, 2022

Bug: UI border of cards on dashboards piitaya/lovelace-mushroom#839

Closed

ildar170975 mentioned this pull request Nov 30, 2022

Borders... #51

Open

piitaya mentioned this pull request Mar 13, 2023

2022.11 b0 - Ugly white card borders home-assistant/frontend#14204

Closed

3 tasks

ildar170975 mentioned this pull request Aug 5, 2023

Unable to hide border between two stacked vertical cards #59

Closed

2 tasks

Rudd-O approved these changes Sep 18, 2023

View reviewed changes

Kalitsune mentioned this pull request Jan 2, 2024

Allow overflow #42

Open

stickpin mentioned this pull request Mar 8, 2024

2024.3: Margins between cards became not controllable #66

Open

Update README.md

bd126ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Home Assistant 2022.11 compatibility #47

Home Assistant 2022.11 compatibility #47

ov1d1u commented Nov 3, 2022

piitaya commented Nov 3, 2022

ov1d1u commented Nov 3, 2022

Getslow6 commented Nov 4, 2022

ov1d1u commented Nov 4, 2022

Rudd-O commented Nov 5, 2022

Rudd-O commented Nov 5, 2022

correctomundo79 commented Nov 7, 2022 •

edited

Getslow6 commented Nov 7, 2022

correctomundo79 commented Nov 7, 2022

strikeir13 commented Nov 9, 2022

ronaldheft commented Nov 9, 2022

strikeir13 commented Nov 9, 2022

Rudd-O commented Nov 10, 2022

amjidkhan commented Nov 11, 2022

amjidkhan commented Nov 11, 2022

almighty059 commented Nov 12, 2022

Rudd-O left a comment

ov1d1u commented Nov 14, 2022 •

edited

almighty059 commented Nov 14, 2022

ov1d1u commented Nov 15, 2022

almighty059 commented Nov 16, 2022 •

edited

ildar170975 commented Nov 30, 2022

ViktuK359 commented Dec 8, 2022

bokub commented Mar 1, 2023

Rudd-O commented Mar 1, 2023

bokub commented Mar 2, 2023

Rudd-O commented Mar 3, 2023

ncd7 commented Sep 10, 2023

Kalitsune commented Jan 2, 2024

ildar170975 commented Jan 30, 2024

Home Assistant 2022.11 compatibility #47

Are you sure you want to change the base?

Home Assistant 2022.11 compatibility #47

Conversation

ov1d1u commented Nov 3, 2022

piitaya commented Nov 3, 2022

ov1d1u commented Nov 3, 2022

Getslow6 commented Nov 4, 2022

ov1d1u commented Nov 4, 2022

Rudd-O commented Nov 5, 2022

Rudd-O commented Nov 5, 2022

correctomundo79 commented Nov 7, 2022 • edited

Getslow6 commented Nov 7, 2022

correctomundo79 commented Nov 7, 2022

strikeir13 commented Nov 9, 2022

ronaldheft commented Nov 9, 2022

strikeir13 commented Nov 9, 2022

Rudd-O commented Nov 10, 2022

amjidkhan commented Nov 11, 2022

amjidkhan commented Nov 11, 2022

almighty059 commented Nov 12, 2022

Rudd-O left a comment

Choose a reason for hiding this comment

ov1d1u commented Nov 14, 2022 • edited

almighty059 commented Nov 14, 2022

ov1d1u commented Nov 15, 2022

almighty059 commented Nov 16, 2022 • edited

ildar170975 commented Nov 30, 2022

ViktuK359 commented Dec 8, 2022

bokub commented Mar 1, 2023

Rudd-O commented Mar 1, 2023

bokub commented Mar 2, 2023

Rudd-O commented Mar 3, 2023

ncd7 commented Sep 10, 2023

Kalitsune commented Jan 2, 2024

ildar170975 commented Jan 30, 2024

correctomundo79 commented Nov 7, 2022 •

edited

ov1d1u commented Nov 14, 2022 •

edited

almighty059 commented Nov 16, 2022 •

edited