Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added exception handling for when browser doesn't exist #271

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

Shahroz16
Copy link
Contributor

@Shahroz16 Shahroz16 commented Oct 17, 2023

fixes: #270

Testing:

  • This is how i replicated, created a new emulator
  • Run the command
adb shell pm uninstall --user 0 com.google.android.webview

Verified the app didn't crash when an in-app was recieved.

@Shahroz16 Shahroz16 marked this pull request as ready for review October 17, 2023 13:31
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: shahroz/fix-no-browser (1697550821)
  • kotlin_compose: shahroz/fix-no-browser (1697550822)

@Shahroz16 Shahroz16 self-assigned this Oct 17, 2023
@Shahroz16 Shahroz16 requested a review from a team October 17, 2023 13:32
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #271 (2193b56) into main (7588700) will decrease coverage by 0.11%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main     #271      +/-   ##
============================================
- Coverage     50.84%   50.73%   -0.11%     
  Complexity      249      249              
============================================
  Files           108      108              
  Lines          2779     2785       +6     
  Branches        361      362       +1     
============================================
  Hits           1413     1413              
- Misses         1249     1255       +6     
  Partials        117      117              
Files Coverage Δ
...inginapp/gist/presentation/engine/EngineWebView.kt 0.00% <0.00%> (ø)

@github-actions
Copy link

Build available to test
Version: shahroz-fix-no-browser-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the details on testing 👍🏻

@Shahroz16 Shahroz16 merged commit aaddad5 into main Oct 17, 2023
26 of 30 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/fix-no-browser branch October 17, 2023 14:05
github-actions bot pushed a commit that referenced this pull request Oct 17, 2023
## [3.6.7](3.6.6...3.6.7) (2023-10-17)

### Bug Fixes

* added exception handling for when browser doesn't exist ([#271](#271)) ([aaddad5](aaddad5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with EngineWebView
2 participants