Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use maven style dependency range syntax #171

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

jatinn
Copy link
Contributor

@jatinn jatinn commented Feb 16, 2023

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

@jatinn jatinn requested a review from a team February 16, 2023 16:55
@ami-oss-ci
Copy link

ami-oss-ci commented Feb 16, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #171 (5a855a6) into beta (7d528dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               beta     #171   +/-   ##
=========================================
  Coverage     62.12%   62.12%           
  Complexity      210      210           
=========================================
  Files            91       91           
  Lines          2041     2041           
  Branches        257      257           
=========================================
  Hits           1268     1268           
  Misses          676      676           
  Partials         97       97           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Build available to test
Version: dependency-syntax-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@jatinn jatinn merged commit ba83214 into beta Feb 16, 2023
@jatinn jatinn deleted the dependency-syntax branch February 16, 2023 17:20
ami-ci pushed a commit that referenced this pull request Feb 16, 2023
## [3.3.0-beta.3](3.3.0-beta.2...3.3.0-beta.3) (2023-02-16)

### Bug Fixes

* use maven style dependency range syntax ([#171](#171)) ([ba83214](ba83214))
@ami-ci
Copy link
Contributor

ami-ci commented Feb 16, 2023

🎉 This PR is included in version 3.3.0-beta.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 22, 2023
## [3.3.0](3.2.0...3.3.0) (2023-02-22)

### Features

* add setting a in-app event listener ([#147](#147)) ([5fd9559](5fd9559))
* in-app feature no longer requires orgId ([#163](#163)) ([fc2a08e](fc2a08e))

### Bug Fixes

* image not shown when image url in notification payload ([#172](#172)) ([0abdc85](0abdc85))
* moved shared wrapper code ([#158](#158)) ([51af98f](51af98f))
* remove currentRoute parameter in in-app event listener ([#159](#159)) ([688e4a5](688e4a5))
* rename in app listener keys ([#164](#164)) ([f540eaf](f540eaf))
* set gist dependency to use latest 3.X.Y version ([#170](#170)) ([a019c36](a019c36))
* set gist user token incase identifier exists ([#162](#162)) ([44cc4d1](44cc4d1))
* update CustomerIOFirebaseMessagingService to open ([#174](#174)) ([edce7f5](edce7f5))
* upgrade dependencies ([#146](#146)) ([6da8b8d](6da8b8d))
* use maven style dependency range syntax ([#171](#171)) ([ba83214](ba83214))
@github-actions
Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants