Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expo-notifications compatibility with customerio-expo-plugin #70

Merged
merged 4 commits into from May 11, 2023

Conversation

xtreem88
Copy link
Collaborator

Resolves: https://github.com/customerio/opsbugs/issues/3389

Solution:
Call the following in didRegisterForRemoteNotificationsWithDeviceToken delegate method.
[super application:application didRegisterForRemoteNotificationsWithDeviceToken:deviceToken]

Example:

- (void)application:(UIApplication *)application didRegisterForRemoteNotificationsWithDeviceToken:(NSData *)deviceToken
{
  [super application:application didRegisterForRemoteNotificationsWithDeviceToken:deviceToken]
  return [pnHandlerObj application:application deviceToken:deviceToken];
}

@github-actions
Copy link

github-actions bot commented May 10, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@xtreem88 xtreem88 changed the title expo-notifications compatibility with customerio-expo-plugin fix: expo-notifications compatibility with customerio-expo-plugin May 10, 2023
Copy link
Contributor

@ami-aman ami-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ami-aman ami-aman merged commit fe5cd0f into beta May 11, 2023
3 checks passed
@ami-aman ami-aman deleted the expo-notifications-incompatible-with-customerio branch May 11, 2023 14:16
github-actions bot pushed a commit that referenced this pull request May 11, 2023
## [1.0.0-beta.8](1.0.0-beta.7...1.0.0-beta.8) (2023-05-11)

### Bug Fixes

* expo-notifications compatibility with customerio-expo-plugin ([#70](#70)) ([fe5cd0f](fe5cd0f))
@zdnk
Copy link

zdnk commented May 11, 2023

With this fix you are still overriding behavior for received push notifications etc. Event if they are not CustomerIO notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants