Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expo-notifications compatibility with customerio-expo-plugin #70

Merged
merged 4 commits into from May 11, 2023
Merged

fix: expo-notifications compatibility with customerio-expo-plugin #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea67d74
fix
xtreem88 May 10, 2023
8824e1b
refactor
xtreem88 May 10, 2023
f51ac69
fix
xtreem88 May 10, 2023
5f25a98
minor fix that was breaking app building
ami-aman May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/helpers/constants/ios.ts
View file
Open in desktop
Expand Up @@ -40,10 +40,12 @@ CIOAppPushNotificationsHandler* pnHandlerObj = [[CIOAppPushNotificationsHandler
`;

export const CIO_DIDFAILTOREGISTERFORREMOTENOTIFICATIONSWITHERROR_SNIPPET = `
[super application:application didFailToRegisterForRemoteNotificationsWithError:error];
[pnHandlerObj application:application error:error];
`;

export const CIO_DIDREGISTERFORREMOTENOTIFICATIONSWITHDEVICETOKEN_SNIPPET = `
[super application:application didRegisterForRemoteNotificationsWithDeviceToken:deviceToken];
return [pnHandlerObj application:application deviceToken:deviceToken];
`;

Expand Down
4 changes: 2 additions & 2 deletions src/ios/withAppDelegateModifications.ts
View file
Open in desktop
Expand Up @@ -88,7 +88,7 @@ const addDidFailToRegisterForRemoteNotificationsWithError = (
return stringContents;
};

const AddDidRegisterForRemoteNotificationsWithDeviceToken = (
const addDidRegisterForRemoteNotificationsWithDeviceToken = (
stringContents: string
) => {
stringContents = injectCodeByMultiLineRegexAndReplaceLine(
Expand Down Expand Up @@ -155,7 +155,7 @@ export const withAppDelegateModifications: ConfigPlugin<
stringContents =
addDidFailToRegisterForRemoteNotificationsWithError(stringContents);
stringContents =
AddDidRegisterForRemoteNotificationsWithDeviceToken(stringContents);
addDidRegisterForRemoteNotificationsWithDeviceToken(stringContents);

config.modResults.contents = stringContents;
} else {
Expand Down