fix: modify in-app event listener action parameters to new name

customerio · Jan 30, 2023 · 6515edf · 6515edf
1 parent ad74ea3
commit 6515edf
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 13 deletions.
diff --git a/Sources/MessagingInApp/MessagingInAppImplementation.swift b/Sources/MessagingInApp/MessagingInAppImplementation.swift
@@ -110,8 +110,8 @@ extension MessagingInAppImplementation: GistDelegate {
 
         eventListener?.messageActionTaken(
             message: InAppMessage(gistMessage: message),
-            action: action,
-            name: name
+            actionValue: action,
+            actionName: name
         )
     }
 

diff --git a/Sources/MessagingInApp/Type/InAppEventListener.swift b/Sources/MessagingInApp/Type/InAppEventListener.swift
@@ -6,5 +6,5 @@ public protocol InAppEventListener: AutoMockable {
     func messageShown(message: InAppMessage)
     func messageDismissed(message: InAppMessage)
     func errorWithMessage(message: InAppMessage)
-    func messageActionTaken(message: InAppMessage, action: String, name: String)
+    func messageActionTaken(message: InAppMessage, actionValue: String, actionName: String)
 }
diff --git a/Sources/MessagingInApp/autogenerated/AutoMockable.generated.swift b/Sources/MessagingInApp/autogenerated/AutoMockable.generated.swift
@@ -211,21 +211,21 @@ public class InAppEventListenerMock: InAppEventListener, Mock {
     }
 
     /// The arguments from the *last* time the function was called.
-    public private(set) var messageActionTakenReceivedArguments: (message: InAppMessage, action: String, name: String)?
+    public private(set) var messageActionTakenReceivedArguments: (message: InAppMessage, actionValue: String, actionName: String)?
     /// Arguments from *all* of the times that the function was called.
-    public private(set) var messageActionTakenReceivedInvocations: [(message: InAppMessage, action: String, name: String)] = []
+    public private(set) var messageActionTakenReceivedInvocations: [(message: InAppMessage, actionValue: String, actionName: String)] = []
     /**
      Set closure to get called when function gets called. Great way to test logic or return a value for the function.
      */
     public var messageActionTakenClosure: ((InAppMessage, String, String) -> Void)?
 
-    /// Mocked function for `messageActionTaken(message: InAppMessage, action: String, name: String)`. Your opportunity to return a mocked value and check result of mock in test code.
-    public func messageActionTaken(message: InAppMessage, action: String, name: String) {
+    /// Mocked function for `messageActionTaken(message: InAppMessage, actionValue: String, actionName: String)`. Your opportunity to return a mocked value and check result of mock in test code.
+    public func messageActionTaken(message: InAppMessage, actionValue: String, actionName: String) {
         mockCalled = true
         messageActionTakenCallsCount += 1
-        messageActionTakenReceivedArguments = (message: message, action: action, name: name)
-        messageActionTakenReceivedInvocations.append((message: message, action: action, name: name))
-        messageActionTakenClosure?(message, action, name)
+        messageActionTakenReceivedArguments = (message: message, actionValue: actionValue, actionName: actionName)
+        messageActionTakenReceivedInvocations.append((message: message, actionValue: actionValue, actionName: actionName))
+        messageActionTakenClosure?(message, actionValue, actionName)
     }
 }
 

diff --git a/Tests/MessagingInApp/APITest.swift b/Tests/MessagingInApp/APITest.swift
@@ -41,5 +41,5 @@ extension MessagingInAppAPITest: InAppEventListener {
 
     func errorWithMessage(message: InAppMessage) {}
 
-    func messageActionTaken(message: InAppMessage, action: String, name: String) {}
+    func messageActionTaken(message: InAppMessage, actionValue: String, actionName: String) {}
 }
diff --git a/Tests/MessagingInApp/MessagingInAppImplementationTest.swift b/Tests/MessagingInApp/MessagingInAppImplementationTest.swift
@@ -132,8 +132,8 @@ class MessagingInAppImplementationTest: UnitTest {
         )
         XCTAssertEqual(eventListenerMock.messageActionTakenCallsCount, 1)
         XCTAssertEqual(eventListenerMock.messageActionTakenReceivedArguments?.message, expectedInAppMessage)
-        XCTAssertEqual(eventListenerMock.messageActionTakenReceivedArguments?.action, givenAction)
-        XCTAssertEqual(eventListenerMock.messageActionTakenReceivedArguments?.name, givenName)
+        XCTAssertEqual(eventListenerMock.messageActionTakenReceivedArguments?.actionValue, givenAction)
+        XCTAssertEqual(eventListenerMock.messageActionTakenReceivedArguments?.actionName, givenName)
     }
 
     func test_eventListeners_expectCallListenerForEachEvent() {