Skip to content

Commit

Permalink
fix: internal module Common clashing with other Common modules in cus…
Browse files Browse the repository at this point in the history
…tomers app (#328)
  • Loading branch information
levibostian committed May 26, 2023
1 parent 3a9085c commit 817dd56
Show file tree
Hide file tree
Showing 96 changed files with 108 additions and 108 deletions.
2 changes: 1 addition & 1 deletion CustomerIOCommon.podspec
Expand Up @@ -18,5 +18,5 @@ Pod::Spec.new do |spec|
# spec.tvos.deployment_target = '13.0'

spec.source_files = "Sources/Common/**/*"
spec.module_name = "Common" # the `import X` name when using SDK in Swift files
spec.module_name = "CioInternalCommon" # the `import X` name when using SDK in Swift files
end
10 changes: 5 additions & 5 deletions Makefile
Expand Up @@ -6,11 +6,11 @@ SHELL = /bin/sh
# imports - Import statements to be at the top of the generated files in case the file needs classes from other modules. Split by `-` (example: `imports=Cio-Foo-Bar`)
generate:
sourcery --sources Sources/Common --templates Sources/Templates --output Sources/Common/autogenerated
sourcery --sources Sources/Tracking --templates Sources/Templates --output Sources/Tracking/autogenerated --args imports=Common
sourcery --sources Sources/MessagingPush --templates Sources/Templates --output Sources/MessagingPush/autogenerated --args imports=CioTracking-Common
sourcery --sources Sources/MessagingPushAPN --templates Sources/Templates --output Sources/MessagingPushAPN/autogenerated --args imports=CioMessagingPush-CioTracking-Common
sourcery --sources Sources/MessagingPushFCM --templates Sources/Templates --output Sources/MessagingPushFCM/autogenerated --args imports=CioMessagingPush-CioTracking-Common
sourcery --sources Sources/MessagingInApp --templates Sources/Templates --output Sources/MessagingInApp/autogenerated --args imports=CioTracking-Common-Gist
sourcery --sources Sources/Tracking --templates Sources/Templates --output Sources/Tracking/autogenerated --args imports=CioInternalCommon
sourcery --sources Sources/MessagingPush --templates Sources/Templates --output Sources/MessagingPush/autogenerated --args imports=CioTracking-CioInternalCommon
sourcery --sources Sources/MessagingPushAPN --templates Sources/Templates --output Sources/MessagingPushAPN/autogenerated --args imports=CioMessagingPush-CioTracking-CioInternalCommon
sourcery --sources Sources/MessagingPushFCM --templates Sources/Templates --output Sources/MessagingPushFCM/autogenerated --args imports=CioMessagingPush-CioTracking-CioInternalCommon
sourcery --sources Sources/MessagingInApp --templates Sources/Templates --output Sources/MessagingInApp/autogenerated --args imports=CioTracking-CioInternalCommon-Gist

lint:
swiftlint lint --strict
Expand Down
8 changes: 4 additions & 4 deletions Package.swift
Expand Up @@ -31,14 +31,14 @@ let package = Package(
targets: [
// Common - Code used by multiple modules in the SDK project.
// this module is *not* exposed to the public. It's used internally.
.target(name: "Common",
.target(name: "CioInternalCommon",
path: "Sources/Common"),
.testTarget(name: "CommonTests",
dependencies: ["SharedTests"],
path: "Tests/Common"),
// Tracking
.target(name: "CioTracking",
dependencies: ["Common"],
dependencies: ["CioInternalCommon"],
path: "Sources/Tracking"),
.testTarget(name: "TrackingTests",
dependencies: ["CioTracking", "SharedTests"],
Expand All @@ -54,7 +54,7 @@ let package = Package(

// Messaging Push
.target(name: "CioMessagingPush",
dependencies: ["Common", "CioTracking"],
dependencies: ["CioTracking"],
path: "Sources/MessagingPush"),
.testTarget(name: "MessagingPushTests",
dependencies: ["CioMessagingPush", "SharedTests"],
Expand All @@ -77,7 +77,7 @@ let package = Package(

// Messaging in-app
.target(name: "CioMessagingInApp",
dependencies: ["Common", "CioTracking", "Gist"],
dependencies: ["CioTracking", "Gist"],
path: "Sources/MessagingInApp"),
.testTarget(name: "MessagingInAppTests",
dependencies: ["CioMessagingInApp", "SharedTests"],
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingInApp/MessagingInApp.swift
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation
import Gist

Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingInApp/MessagingInAppImplementation.swift
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation
import Gist

Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingInApp/Provider/InAppProvider.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
import Gist

Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingInApp/Type/InAppEventListener.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
import Gist

Expand Down
Expand Up @@ -2,8 +2,8 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioTracking
import Common
import Foundation
import Gist

Expand Down
Expand Up @@ -2,8 +2,8 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioTracking
import Common
import Foundation
import Gist

Expand Down
Expand Up @@ -9,8 +9,8 @@ import FoundationNetworking
#if canImport(UserNotifications)
import UserNotifications
#endif
import CioInternalCommon
import CioTracking
import Common
import Gist

/**
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingInApp/hooks/HookProvider.swift
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation

// sourcery: InjectRegister = "ModuleHookProvider"
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/CustomerIOParsedPushPayload.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/MessagingPush+AppDelegate.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/MessagingPush.swift
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation

/**
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/MessagingPushImplementation.swift
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation
#if canImport(UserNotifications) && canImport(UIKit)
import UIKit
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/MessagingPushInstance.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation
#if canImport(UserNotifications) && canImport(UIKit)
import UIKit
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/RichPush/RichPushRequest.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
@@ -1,5 +1,5 @@
import CioInternalCommon
import CioTracking
import Common
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPush/Util/DeepLinkUtil.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation
#if canImport(UIKit)
import UIKit
Expand Down
Expand Up @@ -2,8 +2,8 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioTracking
import Common
import Foundation

/**
Expand Down
Expand Up @@ -2,8 +2,8 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioTracking
import Common
import Foundation

/**
Expand Down
Expand Up @@ -9,8 +9,8 @@ import FoundationNetworking
#if canImport(UserNotifications)
import UserNotifications
#endif
import CioInternalCommon
import CioTracking
import Common

/**
######################################################
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPushAPN/MessagingPushAPN.swift
@@ -1,6 +1,6 @@
import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
Expand Up @@ -2,9 +2,9 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common
import Foundation

/**
Expand Down
Expand Up @@ -2,9 +2,9 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common
import Foundation

/**
Expand Down
Expand Up @@ -9,9 +9,9 @@ import FoundationNetworking
#if canImport(UserNotifications)
import UserNotifications
#endif
import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common

/**
######################################################
Expand Down
2 changes: 1 addition & 1 deletion Sources/MessagingPushFCM/MessagingPushFCM.swift
@@ -1,6 +1,6 @@
import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common
import Foundation
#if canImport(UserNotifications)
import UserNotifications
Expand Down
Expand Up @@ -2,9 +2,9 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common
import Foundation

/**
Expand Down
Expand Up @@ -2,9 +2,9 @@
// DO NOT EDIT
// swiftlint:disable all

import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common
import Foundation

/**
Expand Down
Expand Up @@ -9,9 +9,9 @@ import FoundationNetworking
#if canImport(UserNotifications)
import UserNotifications
#endif
import CioInternalCommon
import CioMessagingPush
import CioTracking
import Common

/**
######################################################
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/Background Queue/QueueRunner.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

// Queue tasks for the Tracking module.
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/CustomerIO.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

public protocol CustomerIOInstance: AutoMockable {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/CustomerIOError.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

/**
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/CustomerIOImplementation.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

/**
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/ModuleTopLevelObject.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

// Base class meant to be subclassed by top-level classes such as `MessagingPush` and `MessagingInApp`. Provides some
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/Repository/CleanupRepository.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

internal protocol CleanupRepository: AutoMockable {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/Service/Request/MetricRequest.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

// https://customer.io/docs/api/#operation/pushMetrics
Expand Down
12 changes: 6 additions & 6 deletions Sources/Tracking/Type/Aliases.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

/*
Expand All @@ -8,8 +8,8 @@ import Foundation
in 'Common' as they are used in the 'Common' code.
*/

public typealias Region = Common.Region
public typealias CioLogLevel = Common.CioLogLevel
public typealias CioSdkConfig = Common.SdkConfig
public typealias CioNotificationServiceExtensionSdkConfig = Common.NotificationServiceExtensionSdkConfig
public typealias Metric = Common.Metric
public typealias Region = CioInternalCommon.Region
public typealias CioLogLevel = CioInternalCommon.CioLogLevel
public typealias CioSdkConfig = CioInternalCommon.SdkConfig
public typealias CioNotificationServiceExtensionSdkConfig = CioInternalCommon.NotificationServiceExtensionSdkConfig
public typealias Metric = CioInternalCommon.Metric
2 changes: 1 addition & 1 deletion Sources/Tracking/Util/DeviceAttributesProvider.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

internal protocol DeviceAttributesProvider: AutoMockable {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/Util/SdkInitializedUtil.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

public protocol SdkInitializedUtil: AutoMockable {
Expand Down
Expand Up @@ -2,7 +2,7 @@
// DO NOT EDIT
// swiftlint:disable all

import Common
import CioInternalCommon
import Foundation

/**
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/autogenerated/AutoLenses.generated.swift
Expand Up @@ -2,7 +2,7 @@
// DO NOT EDIT
// swiftlint:disable all

import Common
import CioInternalCommon
import Foundation

/**
Expand Down
Expand Up @@ -9,7 +9,7 @@ import FoundationNetworking
#if canImport(UserNotifications)
import UserNotifications
#endif
import Common
import CioInternalCommon

/**
######################################################
Expand Down
2 changes: 1 addition & 1 deletion Sources/Tracking/hooks/TrackingModuleHookProvider.swift
@@ -1,4 +1,4 @@
import Common
import CioInternalCommon
import Foundation

class TrackingModuleHookProvider: ModuleHookProvider {
Expand Down

0 comments on commit 817dd56

Please sign in to comment.