build: edit git hooks to not block pushing (#374)

.github/workflows/lint.yml

@@ -8,16 +8,12 @@ jobs:
     runs-on: macos-latest
     steps:
       - uses: actions/checkout@v3
-      - name: Install swiftformat 
-        run: brew install swiftformat || brew upgrade swiftformat 
+      - name: Install swiftformat and swiftlint 
+        run: |
+          brew update # verifies brew knows latest versions of all CLIs
+          brew install swiftformat || brew upgrade swiftformat 
+          brew install swiftlint || brew upgrade swiftlint 
       - name: Run swiftformat. Fail if any errors. 
         run: make format && git diff --exit-code
-
-  SwiftLint:
-    runs-on: macos-latest
-    steps:
-      - uses: actions/checkout@v3
-      - name: Install swiftlint 
-        run: brew install swiftlint || brew upgrade swiftlint 
       - name: Run swiftlint. Fail if any errors. 
         run: make lint

Sources/Common/Store/QueueInventoryMemoryStore.swift

@@ -1,7 +1,7 @@
 import Foundation
 
 // In-memory store of the BQ inventory. This acts as a cache to unnecessary reading the file system from the file system.
-internal protocol QueueInventoryMemoryStore {
+protocol QueueInventoryMemoryStore {
     var inventory: [QueueTaskMetadata]? { get set }
 }
 

Sources/Common/autogenerated/AutoDependencyInjection.generated.swift

@@ -391,12 +391,12 @@ extension DIGraph {
     }
 
     // QueueInventoryMemoryStore (singleton)
-    internal var queueInventoryMemoryStore: QueueInventoryMemoryStore {
+    var queueInventoryMemoryStore: QueueInventoryMemoryStore {
         getOverriddenInstance() ??
             sharedQueueInventoryMemoryStore
     }
 
-    internal var sharedQueueInventoryMemoryStore: QueueInventoryMemoryStore {
+    var sharedQueueInventoryMemoryStore: QueueInventoryMemoryStore {
         // Use a DispatchQueue to make singleton thread safe. You must create unique dispatchqueues instead of using 1 shared one or you will get a crash when trying
         // to call DispatchQueue.sync{} while already inside another DispatchQueue.sync{} call.
         DispatchQueue(label: "DIGraph_QueueInventoryMemoryStore_singleton_access").sync {

lefthook.yml

@@ -14,4 +14,5 @@ pre-push:
   commands:
     lint: 
       # Run linter giving you errors to fix. 
-      run: make lint
+      # By using `|| echo "..."`, we do not block you from pushing code. Running lint in a git hooks is to warn you about lint errors early, but not block you from pushing code with errors if you decide to push.
+      run: make lint || echo -e "\n\n ⚠️  Linting contains errors that will prevent you from merging a pull request. Fix errors above if you are planning on making a pull request."