Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduce 1.2.8 bug in v2 to see if exists #244

Merged
merged 2 commits into from Jan 9, 2023

Conversation

levibostian
Copy link
Member

  • tests: reproduce bug
  • tests: reproduce 1.2.8 bug in v2 to see if exists

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request. A bot will squash and merge the pull request for you after the label is added.

@ami-oss-ci
Copy link

ami-oss-ci commented Jan 6, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will not cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@levibostian levibostian changed the title levi/add test v2 from 1.2.8 bug tests: reproduce 1.2.8 bug in v2 to see if exists Jan 6, 2023
@levibostian levibostian self-assigned this Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #244 (877efd9) into develop (d55a8ca) will increase coverage by 0.35%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #244      +/-   ##
===========================================
+ Coverage    52.94%   53.30%   +0.35%     
===========================================
  Files          101      101              
  Lines         1120     1120              
===========================================
+ Hits           593      597       +4     
+ Misses         527      523       -4     
Impacted Files Coverage Δ
...ogenerated/AutoDependencyInjection.generated.swift 100.00% <0.00%> (+1.63%) ⬆️
Sources/Tracking/CustomerIO.swift 74.19% <0.00%> (+6.45%) ⬆️
Sources/Common/Util/ThreadUtil.swift 50.00% <0.00%> (+50.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@matt-frizzell matt-frizzell requested a review from a team January 9, 2023 04:14
import XCTest

class MessagingInAppIntegrationTests: IntegrationTest {
// Bug reported when: using in-app messaging, debug logging enabled, and using iOS version 1.2.8.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to mention that the bug is not present in 1.2.7 but just 1.2.8.

Copy link
Contributor

@ami-aman ami-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, rest everything looks good.

@levibostian levibostian changed the title tests: reproduce 1.2.8 bug in v2 to see if exists test: reproduce 1.2.8 bug in v2 to see if exists Jan 9, 2023
@levibostian levibostian merged commit 81a8318 into develop Jan 9, 2023
@levibostian levibostian deleted the levi/add-test-v2-from-1.2.8-bug branch January 9, 2023 14:40
@github-actions
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants