Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support json array in attributes #358

Merged
merged 10 commits into from
Jul 26, 2023
Merged

Conversation

mrehan27
Copy link
Contributor

@mrehan27 mrehan27 commented Jul 20, 2023

fixes: https://github.com/customerio/issues/issues/10475

Changes

  • Updated StringAnyEncodable to encode arrays recursively

Tested On

  • React Native (APN Sample App)
  • Flutter (Sample App)
  • iOS (CocoaPods-FCM)

@mrehan27 mrehan27 requested a review from a team July 20, 2023 14:29
@mrehan27 mrehan27 self-assigned this Jul 20, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN-UIKit: rehan/json-array-encoding (1690362172)
  • CocoaPods-FCM: rehan/json-array-encoding (1690362265)

@ami-aman
Copy link
Contributor

@mrehan27 Please test this with wrapper packages as well. I don't see this as a note in the description.

@mrehan27
Copy link
Contributor Author

Thanks @ami-aman. Already tested with React Native and sample data in linked ticket, will test with Flutter too. Updated descriptions for clarity.

@mrehan27 mrehan27 marked this pull request as ready for review July 24, 2023 12:12
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added couple of comments

Tests/Common/Util/StringAnyEncodable.swift Outdated Show resolved Hide resolved
Sources/Common/Util/StringAnyEncodable.swift Outdated Show resolved Hide resolved
Sources/Common/Util/StringAnyEncodable.swift Outdated Show resolved Hide resolved
Tests/Common/Util/StringAnyEncodable.swift Outdated Show resolved Hide resolved
Tests/Common/Util/StringAnyEncodable.swift Show resolved Hide resolved
@mrehan27 mrehan27 merged commit a634358 into main Jul 26, 2023
10 checks passed
@mrehan27 mrehan27 deleted the rehan/json-array-encoding branch July 26, 2023 10:43
github-actions bot pushed a commit that referenced this pull request Jul 26, 2023
## [2.7.7](2.7.6...2.7.7) (2023-07-26)

### Bug Fixes

* support json array in attributes ([#358](#358)) ([a634358](a634358))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants