Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cocoapods APN customers app not compiling #414

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

levibostian
Copy link
Member

Fixes: #178 (comment)

The CI server was not able to catch this bug for us because this bug is specific to APN and cocoapods. Our CI server is only testing cocoapods and FCM.

This PR modifies CI tests to now test for APN compilation as well to prevent bugs like this in future.

Copy link

github-actions bot commented Nov 22, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN-UIKit: levi/compile-apn-2.10.0 (1700669895)
  • CocoaPods-FCM: levi/compile-apn-2.10.0 (1700669950)

@@ -2,13 +2,15 @@ import Foundation
import UIKit

extension MessagingPushAPN {
@available(iOSApplicationExtension, unavailable)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additions to this file match what the FCM equivalent file contains.

@levibostian levibostian requested a review from a team November 22, 2023 16:18
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1226 lines in your changes are missing coverage. Please review.

Comparison is base (9dad7f3) 56.11% compared to head (08011bf) 58.36%.
Report is 140 commits behind head on main.

Files Patch % Lines
.../MessagingInApp/Gist/Managers/MessageManager.swift 12.96% 188 Missing ⚠️
...s/MessagingInApp/Gist/EngineWeb/AnyEncodable.swift 0.00% 178 Missing ⚠️
Sources/MessagingInApp/Gist/Gist.swift 23.52% 78 Missing ⚠️
...agingInApp/Gist/Managers/MessageQueueManager.swift 25.49% 76 Missing ⚠️
...essagingInApp/Gist/Managers/ModalViewManager.swift 0.00% 73 Missing ⚠️
...rces/MessagingInApp/Gist/EngineWeb/EngineWeb.swift 41.81% 64 Missing ⚠️
...gingInApp/Gist/Views/GistModalViewController.swift 0.00% 53 Missing ⚠️
...es/MessagingInApp/Gist/Managers/QueueManager.swift 0.00% 41 Missing ⚠️
...rces/MessagingInApp/Gist/Managers/LogManager.swift 0.00% 39 Missing ⚠️
...agingInApp/Gist/EngineWeb/EngineEventHandler.swift 0.00% 36 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   56.11%   58.36%   +2.24%     
==========================================
  Files         103      122      +19     
  Lines        1153     4729    +3576     
==========================================
+ Hits          647     2760    +2113     
- Misses        506     1969    +1463     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@levibostian levibostian merged commit e7aaa23 into main Nov 22, 2023
10 checks passed
@levibostian levibostian deleted the levi/compile-apn-2.10.0 branch November 22, 2023 18:05
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
## [2.10.1](2.10.0...2.10.1) (2023-11-22)

### Bug Fixes

* cocoapods APN customers app not compiling ([#414](#414)) ([e7aaa23](e7aaa23))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Won't compile when installed via CocoaPods and using Notification Extension.
2 participants