-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cocoapods APN customers app not compiling #414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
levibostian
commented
Nov 22, 2023
@@ -2,13 +2,15 @@ import Foundation | |||
import UIKit | |||
|
|||
extension MessagingPushAPN { | |||
@available(iOSApplicationExtension, unavailable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The additions to this file match what the FCM equivalent file contains.
Shahroz16
approved these changes
Nov 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
## [2.10.1](2.10.0...2.10.1) (2023-11-22) ### Bug Fixes * cocoapods APN customers app not compiling ([#414](#414)) ([e7aaa23](e7aaa23))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #178 (comment)
The CI server was not able to catch this bug for us because this bug is specific to APN and cocoapods. Our CI server is only testing cocoapods and FCM.
This PR modifies CI tests to now test for APN compilation as well to prevent bugs like this in future.