Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable logging for gist #524

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: enable logging for gist #524

merged 1 commit into from
Feb 14, 2024

Conversation

Shahroz16
Copy link
Contributor

Currently, Gist is following a different logger than CIO. This PR just enabled gist logging in case CIO logging is enabled.

More context: https://customerio.slack.com/archives/C01QYDKD0SU/p1707896913866299

@Shahroz16 Shahroz16 requested a review from a team February 14, 2024 12:43
Copy link

github-actions bot commented Feb 14, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: shahroz/enable-gist-logging (1707914846)
  • APN-UIKit: shahroz/enable-gist-logging (1707914824)

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1134 lines in your changes are missing coverage. Please review.

Comparison is base (9dad7f3) 56.11% compared to head (0045c78) 56.92%.
Report is 153 commits behind head on main.

Files Patch % Lines
...s/MessagingInApp/Gist/EngineWeb/AnyEncodable.swift 0.00% 158 Missing ⚠️
.../MessagingInApp/Gist/Managers/MessageManager.swift 18.58% 127 Missing ⚠️
...agingInApp/Gist/Managers/MessageQueueManager.swift 24.39% 62 Missing ⚠️
...gingPush/UserNotificationsFramework/Wrappers.swift 0.00% 61 Missing ⚠️
...essagingInApp/Gist/Managers/ModalViewManager.swift 0.00% 60 Missing ⚠️
...sFramework/UserNotificationsFrameworkAdapter.swift 6.25% 60 Missing ⚠️
Sources/MessagingInApp/Gist/Gist.swift 32.50% 54 Missing ⚠️
...gingInApp/Gist/Views/GistModalViewController.swift 0.00% 43 Missing ⚠️
...rces/MessagingInApp/Gist/EngineWeb/EngineWeb.swift 50.60% 41 Missing ⚠️
...rces/MessagingInApp/Gist/Managers/LogManager.swift 0.00% 31 Missing ⚠️
... and 49 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   56.11%   56.92%   +0.80%     
==========================================
  Files         103      132      +29     
  Lines        1153     3698    +2545     
==========================================
+ Hits          647     2105    +1458     
- Misses        506     1593    +1087     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shahroz16 Shahroz16 merged commit c786897 into main Feb 14, 2024
10 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/enable-gist-logging branch February 14, 2024 13:38
github-actions bot pushed a commit that referenced this pull request Feb 14, 2024
## [2.11.1](2.11.0...2.11.1) (2024-02-14)

### Bug Fixes

* enable logging for gist ([#524](#524)) ([c786897](c786897))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants