Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert customerio-node to typescript #49

Merged
merged 7 commits into from May 4, 2021
Merged

Convert customerio-node to typescript #49

merged 7 commits into from May 4, 2021

Conversation

mike-engel
Copy link
Collaborator

This finally converts this package to typescript. The goal is to introduce this as a backwards compatible change while providing typescript definitions and code for typescript consumers.

Changes

  • Convert all code to typescript, including tests
  • Add tests to bring coverage up to 100 and establish a coverage threshold there
  • Update ignore files
  • Update nyc, ava, prettier, and sinon

@mike-engel mike-engel added feature request dependencies Pull requests that update a dependency file labels Apr 19, 2021
@mike-engel mike-engel self-assigned this Apr 19, 2021
TODO:
- figure out entry point for TS and normal node users
- Fix nyc coverage
- Update npmignore list
- Update unreleased changelog
- Update examples to use the public API
- Update run scripts
- Update exports for the public API
@mike-engel mike-engel marked this pull request as ready for review April 19, 2021 13:00
@mike-engel mike-engel requested a review from a team April 19, 2021 13:00
swastik
swastik previously approved these changes Apr 19, 2021
lib/api/requests.ts Outdated Show resolved Hide resolved
zamoore
zamoore previously approved these changes Apr 19, 2021
Copy link
Contributor

@zamoore zamoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mike-engel mike-engel dismissed stale reviews from zamoore and swastik via 0cefc76 April 19, 2021 14:58
@mike-engel mike-engel merged commit 6f51ee9 into master May 4, 2021
@mike-engel mike-engel deleted the typescript branch May 4, 2021 12:42
This was referenced May 4, 2021
@mike-engel mike-engel mentioned this pull request May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants