chore: test multiple push event handlers in fcm sample app #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levibostian
changed the title
levibostian
commented
Jun 18, 2024
There was a problem hiding this comment.
This PR is identical in logic to the APN app. Same 3rd party SDK for local push, same callback methods added.
levibostian
commented
Jun 18, 2024
Apps/FCM/ios/Podfile
Outdated
There was a problem hiding this comment.
Only here for testing until the native iOS SDK goes to prod.
Shahroz16
approved these changes
Jun 20, 2024
| push: notification.payload | ||
| }); | ||
|
|
||
| completion({ alert: true, sound: true, badge: true }); |
There was a problem hiding this comment.
nice that they cater the api level check themselves? 🤯
levibostian
force-pushed
the
levi/multiple-push-handlers-sampleapps
branch
from
7a3868c
to
9e16474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: https://linear.app/customerio/issue/MBL-383/[bug]-customer-unable-to-handle-push-notification-event-on-ios-with
Tests this iOS bug fix in FCM sample app, while also testing local push notifications in the app.
This PR:
AppDelegate.After this PR, the FCM sample app will have 3 push event handlers: CIO SDK, rnfirebase, and the host iOS app (AppDelegate). This environment allows us to test the iOS bug that is caused when there are at least 2 push event handlers installed in an app.
Testing:
For all QA tests, we expect that both rnfirebase and the host app are able to handle the push events.