Build and release pipelines for Gist Web #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build on merge to develop Release on tag creation
BernardGatt
reviewed
Apr 19, 2023
| AWS_DEST="web/$RELEASE_VERSION" | ||
| echo "AWS_DEST=$AWS_DEST" >> $GITHUB_ENV | ||
| echo "AWS_DEST=$AWS_DEST" | ||
| - uses: shallwefootball/s3-upload-action@master |
There was a problem hiding this comment.
Can we specify permissions? If uploaded with default permissions only the admin has read permissions.
There was a problem hiding this comment.
You can specify otherwise, but the action by default makes it publicly readable.
BernardGatt
reviewed
Apr 19, 2023
stephen-pope-customer-io
changed the title
|
After merging and looking at the result, I realized this would create an issue when trying to release a hotfix. Imagine this scenario where we have 3.0.0 released and we want to create a hotfix on it 3.0.1 Since master is in sync with develop and release flow will take directly from master, there's no way for us to create a hotfix release. I suggest we:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on merge to develop
Release on tag creation
Task: https://github.com/customerio/issues/issues/9599