Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Add matching command line when warning of destroyed Engine Process #715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Windows: Add matching command line when warning of destroyed Engine Process #715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion projects/lib/src/engineprocess_win.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ EngineProcess::~EngineProcess()
{
if (m_started)
{
qWarning("EngineProcess: Destroyed while process is still running.");
qWarning("EngineProcess: Destroyed while process is still running.\r\n"
"Command line: %s", m_cmdLine.toLatin1().data());
kill();
waitForFinished();
}
Expand Down Expand Up @@ -295,6 +296,7 @@ void EngineProcess::start(const QString& program,

BOOL ok = FALSE;
QString cmd = cmdLine(m_workDir, program, arguments);
m_cmdLine = cmd;
QString wdir = QDir::toNativeSeparators(m_workDir);
ZeroMemory(&m_processInfo, sizeof(m_processInfo));

Expand Down
1 change: 1 addition & 0 deletions projects/lib/src/engineprocess_win.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,7 @@ class LIB_EXPORT EngineProcess : public QIODevice
DWORD m_exitCode;
ExitStatus m_exitStatus;
QString m_workDir;
QString m_cmdLine;
QString m_stdErrFile;
OpenMode m_stdErrFileMode;
PROCESS_INFORMATION m_processInfo;
Expand Down