Added Dorico Support #1187
Added Dorico Support #1187
Conversation
| class TestUserInput(unittest.TestCase): # pragma: no cover | ||
| class TestExternal(unittest.TestCase): # pragma: no cover |
There was a problem hiding this comment.
This is not named TestExternal so that it won't run on CI, where we would have to patch the interactive user inputs so that the job doesn't hang.
There was a problem hiding this comment.
I don't understand the comment.
There was a problem hiding this comment.
The class must not be called TestExternal or it will run and hang our automated testing system.
| @@ -1762,15 +1773,15 @@ def run(): | |||
| else: | |||
| # only if running tests | |||
| t = Test() | |||
| te = TestUserInput() | |||
| te = TestExternal() | |||
There was a problem hiding this comment.
sim, I don't understand the comment. :)
| # run test user input | ||
| # run test external |
There was a problem hiding this comment.
I suppose this shouldn't be 'te' anymore.
There was a problem hiding this comment.
Sorry, I don't understand the comment.
| urlMusic21 = 'https://web.mit.edu/music21' | ||
| urlMusic21 = 'http://web.mit.edu/music21' |
There was a problem hiding this comment.
I'm curious why this unrelated change? Sphinx linkcheck will emit errors for redirects from http -> https, so we just link to https.
There was a problem hiding this comment.
I did not (Intentionally) make any such change.
| urlGettingStarted = 'https://web.mit.edu/music21/doc/' | ||
| urlMusic21List = 'https://groups.google.com/g/music21list' | ||
| urlGettingStarted = 'http://web.mit.edu/music21/doc/' | ||
| urlMusic21List = 'http://groups.google.com/group/music21list' |
There was a problem hiding this comment.
sim., I think Sphinx will complain if we make a change.
| msg.append('Welcome to the music21 Configuration Assistant. You will be guided ' | ||
| + 'through a number of questions to install and set up music21. ' | ||
| msg.append('Welcome the music21 Configuration Assistant. You will be guided ' | ||
| + 'through a number of questions to install and setup music21. ' |
There was a problem hiding this comment.
I'm curious why this unrelated change? Also "set up" is the correct verb phrase here; "setup" is a noun.
There was a problem hiding this comment.
I did not (intentionally) make any such change.
|
@EvilArchitech Hey, I think I figured out what happened here. It's likely you began by editing an outdated version of this file, perhaps from version 6.7, and then uploaded it to GitHub. Instead you'll need to base your changes on an updated version of music21 based on the master branch. You can download it from GitHub and re-upload it if you're more comfortable with uploading than with doing a |
|
Got it, I will take a look at the master. I did the upload only because I have an SSO linked corporate login to GitHub, and it was a pain to switch logins without messing up other repos in MS Code. |
|
I think it'd be easier to close the PR and then open a new one from when you're sure you're on the current music21 master. |
|
Closing so there's no danger of merging. Feel free to open a new PR based on latest master. |
No description provided.