Faster deepcopy from reduce_ex #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this rather than #1463 but some good improvements there that need to be integrated.
|
Realtime improvement: about 10% on small scores. However, not seeing a speedup on Beethoven opus132. 6% slower. Might be some sort of hickup with extra copies of a site? 30000 notes. Or the removal of the duration deepcopy speedups? Will try to fix that. |
faster to just do our own _IMMUTABLE check first. looks like a bigger speedup
|
Removed slowdowns. Good performance now, and it's a simplification to the system in any case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use reduce_ex and the private copy._reconstruct() to take advantage of C-language state for custom deepcopies.
PurgeOrphans after every deepcopy.
Change to derived contextSites -- the derivation origin is included in the context sites. The former behavior looks like a bug.
volume keeps a strong reference to its client.
StreamStatus keeps a strong reference to its client.
Stream.toSoundingPitch checks derivations. This was intended behavior originally but was relying on orphans not being purged to do so.
Stream.measure() [not .measures() nor Score.measure()] gets a substantial speedup by not creating a new Part.
TODO: remove "collect" from .measure() and see if gatherSpanners can also be removed from Score.measure()
Remove weakrefs from getstate several places.