Translate "implicit" attribute of MusicXML measures #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
force-pushed
the
measure-number-implicit
branch
from
7aeb3ba
to
f762344
Compare
jacobtylerwalls
force-pushed
the
measure-number-implicit
branch
from
f762344
to
f18a6e1
Compare
|
I don't like numberImplicit. I think it should be like showMeasureNumber="default/always/never" (maybe with an enum?) numberImplicit sounds like it has something to do with "get measure number from context" but that's not what the MusicXML attribute means. Thanks! |
|
Super amazing! Thank you for the hard work on the fix. It looks great to me. Will figure out what new mypy is complaining about later. Merging! |
|
looking further, I should probably have put this under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested at https://groups.google.com/g/music21list/c/vMaz9wJVPyc.
Used
numberImplicitto rhyme with attributes on MetronomeMark.