Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with bottom menu #13

Closed
felixhahnweilheim opened this issue Mar 16, 2024 · 6 comments
Closed

Issues with bottom menu #13

felixhahnweilheim opened this issue Mar 16, 2024 · 6 comments

Comments

@felixhahnweilheim
Copy link
Contributor

First of all I really like the bottom menu. Thanks for adding it in a free module.

I am testing on Android 13 with an up to date HumHub instance and clean-base.

  1. The active icon has dark background when I first open the site or reload it. When I navigate there from another page it is just darker icon color.

First page load:
Screenshot_20240316_075236_Chrome

Navigating to it:
Screenshot_20240316_080401_Chrome

  1. The Space chooser does not show at all.
    Screenshot_20240316_075300_Chrome
@felixhahnweilheim
Copy link
Contributor Author

  1. an issue with the sidebar. The menu is halfly hidden (but still accessible via scrolling).
    Screenshot_20240316_085313_Chrome

@marc-farre
Copy link
Member

@felixhahnweilheim thanks very much for your feedback.

1/ Fixed in commit 0d9022c
It was due to the fact that when you click on a touch screen, it simulates a "Hover" effect, until you click somewhere else.

2/ Should be fixed in version 1.7.1: https://github.com/cuzy-app/humhub-modules-clean-theme/blob/master/docs/CHANGELOG.md#171-march-11-2024
Do you still have the issue?

3/ The solution is here: humhub/humhub#6889

@felixhahnweilheim
Copy link
Contributor Author

2/ Yes, I am testing with 1.7.1 (did not test 1.7.0).
I also flushed the cache.

Sorry I have no time to investigate today, hopefully the next days.

@marc-farre
Copy link
Member

@felixhahnweilheim Thanks! If you want, I can check what's happening on your instance (in this case, send me a PM with the URL of it and a way to login to see the Space chooser menu item).

@marc-farre
Copy link
Member

@felixhahnweilheim

2/ is fixed in commit 9e0e5dd

3/ will be fixed in HumHub 1.16 from PR humhub/humhub#6890

I will release a new version soon (I might work on content add-on such as comment, like, reaction, etc. before releasing it).

Thanks again!

@felixhahnweilheim
Copy link
Contributor Author

Thanks a lot for your efforts. I can confirm that 1. and 2. are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants