Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with modal boxes when positioning an element at the bottom of the screen #6889

Closed
marc-farre opened this issue Mar 17, 2024 · 2 comments

Comments

@marc-farre
Copy link
Collaborator

@luke- do we still need this?

@media @responsive {
    .modal-open #layout-content {
        > .container {
            overflow-x: unset; // This fixes broken (invisible) richtext editor nav in ios safari...
        }
    }
}

https://github.com/humhub/humhub/blob/master/static/less/mobile.less#L26

Or can I replace it with overflow-x: hidden;?

Or was it for old iOs Safari?

It was added 5 years ago: Commit: 1620171
Because if this issue: #3711

I don't understand why the fix is on .modal-open as the issue doesn't seam to be for modal boxes.

overflow-x: unset; creates a problem with the Clean Theme bottom menu: cuzy-app/clean-theme#13 (comment)

And the only way to fix it is to replace overflow-x: unset; with any other overflow-x value. hidden could be fine.
Thanks!

@luke-
Copy link
Contributor

luke- commented Mar 17, 2024

@marc-farre I think the problem no longer exists. If you would like to set a PR, we can remove this fix.

@marc-farre
Copy link
Collaborator Author

@luke- thanks. PR #6890

github-merge-queue bot pushed a commit that referenced this issue Mar 17, 2024
@luke- luke- closed this as completed Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants