Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an ability to dismiss avatar notifications #39

Open
MadaraUchiha opened this issue Oct 17, 2012 · 3 comments
Open

Have an ability to dismiss avatar notifications #39

MadaraUchiha opened this issue Oct 17, 2012 · 3 comments
Labels
Milestone

Comments

@MadaraUchiha
Copy link

Currently, you have no way of dismissing the Avatar Notifications of cv-pls or delv-pls requests, without actually clicking on it and viewing the message itself.

That is undesireable since it's possible that chat was left on for long, etc.

I wish to request a way to dismiss these, either a cancel button, or a more intuitive ESC click.

@DaveRandom
Copy link
Contributor

We need to agree how this should be implemented. While we could just hook into ESC I personally don't think this is the right solution, because the @mention notifications already use this hook, and I don't necessarily want to dismiss both at once.

@MadaraUchiha
Copy link
Author

Many things use the ESC hook. It can be used to discard a message, close dialogs and dismiss notifications. I don't think that adding another one would harm the user, and it's the most intuitive.

@DaveRandom
Copy link
Contributor

It seems the general consensus on this is to use ESC, we will implement this for the 0.21 and see how we get on with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants