Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support findByIds() query #47

Merged
merged 10 commits into from
Mar 5, 2022
Merged

Support findByIds() query #47

merged 10 commits into from
Mar 5, 2022

Conversation

cvara
Copy link
Owner

@cvara cvara commented Feb 19, 2022

Adds support for findByIds() query.

Things that need to be resolved before merging:

  • Fix Silence typescript issues (ts2349)
  • Homogenize promise/observable result handling
  • Does pagination make sense when using findByIds()? Answer: No, pagination is ignored when using findByIds()
  • Abort promise on component cleanup (aka handle component unmount before promise resolves)
  • Get to 100% coverage

Fixes #46

@cvara cvara added the WIP Work In Progress label Feb 19, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #47 (52c4133) into master (074cd6b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         8    +1     
  Lines          131       160   +29     
  Branches        29        37    +8     
=========================================
+ Hits           131       160   +29     
Impacted Files Coverage Δ
src/useRxData.ts 100.00% <ø> (ø)
src/helpers.ts 100.00% <100.00%> (ø)
src/useRxQuery.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 074cd6b...52c4133. Read the comment docs.

@cvara cvara marked this pull request as ready for review March 5, 2022 17:11
@cvara cvara merged commit 69ac155 into master Mar 5, 2022
@cvara cvara deleted the support-findByIds-return-type branch March 5, 2022 17:12
@cvara cvara removed the WIP Work In Progress label Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useRxData doesn't support findByIds
1 participant