Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after removing a tag #1540

Closed
mkostiv opened this issue May 14, 2020 · 3 comments · Fixed by #1541
Closed

Error after removing a tag #1540

mkostiv opened this issue May 14, 2020 · 3 comments · Fixed by #1541
Assignees
Labels
bug Something isn't working
Projects
Milestone

Comments

@mkostiv
Copy link

mkostiv commented May 14, 2020

Steps to reproduce:

  1. Add a tag to an image
  2. Try to remove tag -> Crash
  3. Reload the page, select the frame with a tag you previously tried to remove
  4. Hover the mouse over the tag -> Crash

TypeError
Cannot read property 'removeClass' of undefined

TypeError: Cannot read property 'removeClass' of undefined
at Mu.deactivateShape (http://34.91.5.56:8080/cvat-ui.min.js:72:1383456)
at Mu.deactivate (http://34.91.5.56:8080/cvat-ui.min.js:72:1383969)
at Mu.activate (http://34.91.5.56:8080/cvat-ui.min.js:72:1386548)
at Mu.notify (http://34.91.5.56:8080/cvat-ui.min.js:72:1376400)
at Cc.notify (http://34.91.5.56:8080/cvat-ui.min.js:72:1293622)
at Cc.activate (http://34.91.5.56:8080/cvat-ui.min.js:72:1296706)
at Lu.activate (http://34.91.5.56:8080/cvat-ui.min.js:72:1391016)
at od.componentDidUpdate (http://34.91.5.56:8080/cvat-ui.min.js:72:1424991)
at yl (http://34.91.5.56:8080/cvat-ui.min.js:43:100837)
at t.unstable_runWithPriority (http://34.91.5.56:8080/cvat-ui.min.js:51:3465)
Screen Shot 2020-05-14 at 9 45 30 PM

@mkostiv
Copy link
Author

mkostiv commented May 14, 2020

git describe 0.2.0-706-g6566e4a

@mkostiv mkostiv changed the title Tags removal Error after removing a tag May 14, 2020
@bsekachev
Copy link
Member

Also found the issue. It is enough just to deactivate a tag.

@ActiveChooN could you please look into this?

@bsekachev bsekachev added the bug Something isn't working label May 14, 2020
@bsekachev bsekachev added this to To do in UI via automation May 14, 2020
@bsekachev bsekachev added this to the 1.0.0-release milestone May 14, 2020
@ActiveChooN
Copy link
Contributor

@bsekachev, maybe it's good idea to add activated shape id checking in cvat-canvas in activation method, is it?

UI automation moved this from To do to Done May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
UI
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants