Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datumaro] Refactor explain and models CLI #1714

Merged
merged 4 commits into from
Jun 17, 2020
Merged

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

  • Actualized RISE command line to be compatible with recent code changes and Support relative paths in import and export #1463
    • Renamed --progressive to --display
  • Updated model CLI:
    • Added auto-generation of output directory names
    • Simplified cli plugins for launchers
  • Removed input image size hint in launcher as unnecessary
  • Removed model_dir from config
  • Changed iteration method for config to be like in dict

How has this been tested?

Manual test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ datumaro/datumaro/cli/commands/explain.py  -1
         

See the complete overview on Codacy

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5761

  • 2 of 24 (8.33%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 65.815%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datumaro/datumaro/components/config.py 0 1 0.0%
datumaro/datumaro/cli/commands/explain.py 0 8 0.0%
datumaro/datumaro/cli/contexts/model/init.py 2 15 13.33%
Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/cli/contexts/model/init.py 2 16.33%
Totals Coverage Status
Change from base Build 5743: 0.02%
Covered Lines: 10922
Relevant Lines: 16197

💛 - Coveralls

@azhavoro azhavoro added this to Reviewer approved in Dataset framework (Datumaro) via automation Jun 17, 2020
@azhavoro azhavoro merged commit be30aa6 into develop Jun 17, 2020
Dataset framework (Datumaro) automation moved this from Reviewer approved to Done Jun 17, 2020
@azhavoro azhavoro deleted the zm/update-explain-command branch June 17, 2020 14:21
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
* Update explain cli

* Update model cli

* Update config for models

* Remove input size hint for models
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants