Added support of ellipses

[bsekachev]

Motivation and context

Resolved #579

TODOs:

• Export import to some formats (<ellipse .. /> in CVAT formats, and masks if the format supports them)
• Add several API tests to cvat-core
• Support new shape type in filters

How has this been tested?

Checklist

• I submit my changes into the develop branch
• I have added a description of my changes into CHANGELOG file
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (read github docs)
• I have increased versions of npm packages if it is necessary (cvat-canvas,
  cvat-core, cvat-data and cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.
• I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

[nmanovic]

@bsekachev , should we keep the shape size/position unchanged if some part of the shape is outside of a frame? Otherwise it is impossible to annotate some objects which are particularly outside of a frame.

[bsekachev]

@nmanovic

For now for all shapes where it is possible we cut shape if it is out of image. Should we cut ellipses or not is it a question. Probably we should (to keep consistensy), but we also need to add an ability to configure this behaviour for all the shapes.

[nmanovic]

@nmanovic

For now for all shapes where it is possible we cut shape if it is out of image. Should we cut ellipses or not is it a question. Probably we should (to keep consistensy), but we also need to add an ability to configure this behavior for all the shapes.

What is the major difference with rotated bounding boxes? From my point of view an ellipse shape and a rotated bounding box are very similar. I agree that it is better to configure the behavior but for some shapes like a rotated bounding box or an ellipse it is impossible to cut them without conversion to a polygon. Also could you please give me an example when the implemented behavior makes sense?

[ActiveChooN]

Hi,
Ellipse is not clipped for the size of the frame as you show in the gif (not only ellipses btw), but in the develop it works fine

Will ellipses support rotation as bounding boxes? Looks like it can be helpful in some cases.

[bsekachev]

@ActiveChooN

Ellipse is not clipped for the size of the frame as you show in the gif (not only ellipses btw), but in the develop it works fine

For ellipses it was changed according to @nmanovic ideas. GIF just is not updated.
For other shapes I will look at the issue

[ActiveChooN]

LGTM

[nmanovic]

@bsekachev , I will recommend to draw an ellipse as it is done by Photoshop and gimp by default. Looks like it is a better way for our scenarios as well. Draw an ellipse and try to annotate it using the current approach when an ellipse is drawing from a center. It will be difficult. Better to fit an ellipse into a virtual bounding box. Thus the interface can be similar to a bounding box but instead of a box, users will get an ellipse fitted into the box.

Need to say that graphical editors support both methods. The current behaviors is supported using ALT+CTRL. But I'm not sure that we need the second method. In real life it is very difficult to find a center of an object.

[nmanovic]

@bsekachev , another idea which is similar for rotated bounding boxes. Rotated shapes better to annotate using 4 points.Thus you can draw a rotated bounding box or fit an ellipse into it.

BTW, how to rotate an ellipse?

[klakhov]

@bsekachev great job! What do you think about quick way to draw a circle? Usually we can hold shift using ellipse tool to draw circles

[bsekachev]

@nmanovic

I will recommend to draw an ellipse as it is done by Photoshop

There was default way to draw ellipses provided by the svg library. Now I redesigned it according to photoshop default way of drawing.

BTW, how to rotate an ellipse?

Actually it was disabled because nobody asked us about rotation of ellipses. Now, If you wish, I enabled it.

another idea which is similar for rotated bounding boxes.

Agree, but it is a different feature where additional design stage is necessary for both bounding boxes and ellipses.

[bsekachev]

@klakhov

That's interesting, but as far as I remember there were not such requests for bounding boxes for years. Maybe nobody needs it? And if we decide to implement the feature, it is probably better to do it for both bounding boxes and ellipses.

[nmanovic]

@klakhov

That's interesting, but as far as I remember there were not such requests for bounding boxes for years. Maybe nobody needs it? And if we decide to implement the feature, it is probably better to do it for both bounding boxes and ellipses.

@bsekachev , @klakhov ,

I agree that it is extremely rare case when you need circle or square. We are annotating real objects, not draw something on the canvas.

P.S. 'bounding box', 'ellipse' should have mostly the same implementation. The only difference is representation (how we are drawing it and export to a file).

[nmanovic]

LGTM

[bsekachev]

@TOsmanov @aschernov

Guys, could you add a piece of documentation about the new supported type of shape?

[bsekachev]

Hi, @dvkruchinin

Could you please add some tests to ellipses?
Drawing shapes, tracks / rotation / interpolation (I have already added a command to draw ellipses actually and updated test with statistics).

[dvkruchinin]

Hi, @dvkruchinin

Could you please add some tests to ellipses? Drawing shapes, tracks / rotation / interpolation (I have already added a command to draw ellipses actually and updated test with statistics).

Hi @bsekachev,
Sure. A test will be prepared.

[TOsmanov]

@TOsmanov @aschernov

Guys, could you add a piece of documentation about the new supported type of shape?

Hi @bsekachev,
Yes, the documentation will be updated

[mshz88]

please help me, why I can't find the ellipse shape in the web version? how to add the ellipse shape?

[bsekachev]

@mshz88

If you speak about cvat.org, the server was not updated yet. We are working on this, but it takes long time because of significant changes in CVAT. I hope the process will be finished the next week.

[mshz88]

Thank you, @bsekachev CVAT is the best tool among others with many features. We are looking forward to seeing the ellipse shape in the updated version.