Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: canvas is busy (at least one reproducing way) #4151

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Jan 12, 2022

Motivation and context

Resolved #3711
Resolved #3652 (related issue)

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jan 12, 2022
@bsekachev bsekachev changed the title [WIP] Fixed bug: canvas is busy (at least one reproducing way) Fixed bug: canvas is busy (at least one reproducing way) Jan 12, 2022
@bsekachev
Copy link
Member Author

@ActiveChooN
Could you please look at the PR?

ActiveChooN
ActiveChooN previously approved these changes Jan 13, 2022
@bsekachev
Copy link
Member Author

@dvkruchinin

Could you please add a test according to the scenario?

  1. Activate an object
  2. Start dragging it (do not release mouse)
  3. Delete it using Del key
  4. Try to activate another object (before fix objects can't be activated)

@bsekachev bsekachev merged commit 1d084c4 into develop Jan 13, 2022
@dvkruchinin
Copy link
Contributor

@dvkruchinin

Could you please add a test according to the scenario?

@bsekachev
Sure. I`ll update a test.

@bsekachev bsekachev deleted the bs/fixed_issue_3711 branch January 13, 2022 18:17
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants