Tus for task annotations import #4327
Conversation
klakhov
changed the title
klakhov
changed the title
|
@bsekachev @nmanovic Could you please take a look at this patch? |
cvat/apps/engine/views.py
Outdated
| # UploadMixin method | ||
| def get_upload_dir(self, data_type): | ||
| db_model = self.get_object() | ||
| if data_type == 'annotations': |
There was a problem hiding this comment.
In the context self is the view. Thus we have self.action. I don't think that we need to pass data_type at all.
There was a problem hiding this comment.
Yes,self.action can help us on init/finish upload. But when we are uploading file with chunks, we use universal append_tus_chunk action where there is no direct information about data_type
There was a problem hiding this comment.
@klakhov , probably it is because append_tus_chunk should be a method, not an action.
|
I've encountered strange problem with instead of This test checked presence of |
|
Hmm, uploading annotations to an empty task does not work for me. UI says "Annotations have been loaded", but the task is still empty. |
|
@klakhov Could you please resolve conflicts? Looks like the same issue is still reproducable for me, or maybe did I miss something? (pull, restart server, restart UI, ... ?) |
|
@nmanovic I've removed |
* add data_type to tus mixin * added tus for task annotations import * added tus for jobs annotations import * applied comments * fix test * fix incorrect upload endpoint * add location creation based on origin * remove unused import * remove data_type * remove unused comment * update changelog to new release Co-authored-by: Nikita Manovich <nikita.manovich@intel.com>
Motivation and context
Continue TUS integration to provide chunk upload for large annotation files in Tasks and Jobs
Resolved #964
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.